From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Barnabás Czémán" <barnabas.czeman@mainlining.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Jonathan Albrieux" <jonathan.albrieux@gmail.com>,
"Gwendal Grignou" <gwendal@chromium.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux@mainlining.org
Subject: Re: [PATCH v4 1/4] iio: magnetometer: ak8975: Relax failure on unknown id
Date: Mon, 26 Aug 2024 11:39:20 +0100 [thread overview]
Message-ID: <20240826113920.092d9ec7@jic23-huawei> (raw)
In-Reply-To: <Zsje0_gd41N1P0eE@black.fi.intel.com>
On Fri, 23 Aug 2024 22:11:15 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Fri, Aug 23, 2024 at 07:32:03PM +0100, Jonathan Cameron wrote:
> > On Mon, 19 Aug 2024 00:29:39 +0200
> > Barnabás Czémán <barnabas.czeman@mainlining.org> wrote:
>
> ...
>
> > > + /* Let driver to probe on unknown id for support more register
> > Comment style wrong, I'll fix it up.
> >
> > With that tweak applied to the togreg branch of iio.git
> >
> > Thanks,
> >
> > Jonathan
> >
> >
> > > + * compatible variants.
> > > + */
>
> There is another one also wrong.
>
> + [AK09918] = {
> + /* ak09918 is register compatible with ak09912 this is for avoid
> + * unknown id messages.
> + */
>
>
I think unrelated to this series, but nice to cleanup.
Patches welcome :) Or it I get bored, I might do a scrub of the full subsystem
to get everything in the same style and not provide incorrect choices to
cut and paste.
Jonathan
next prev parent reply other threads:[~2024-08-26 10:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-18 22:29 [PATCH v4 0/4] Add support for AK09918 Barnabás Czémán
2024-08-18 22:29 ` [PATCH v4 1/4] iio: magnetometer: ak8975: Relax failure on unknown id Barnabás Czémán
2024-08-23 18:32 ` Jonathan Cameron
2024-08-23 19:11 ` Andy Shevchenko
2024-08-26 10:39 ` Jonathan Cameron [this message]
2024-08-26 10:42 ` Andy Shevchenko
2024-08-18 22:29 ` [PATCH v4 2/4] iio: magnetometer: ak8975: Fix reading for ak099xx sensors Barnabás Czémán
2024-08-18 22:29 ` [PATCH v4 3/4] dt-bindings: iio: magnetometer: Add ak09118 Barnabás Czémán
2024-08-18 22:35 ` Conor Dooley
2024-08-18 22:29 ` [PATCH v4 4/4] iio: magnetometer: ak8975: Add AK09118 support Barnabás Czémán
2024-08-23 18:35 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240826113920.092d9ec7@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=barnabas.czeman@mainlining.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gwendal@chromium.org \
--cc=jonathan.albrieux@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@mainlining.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox