public inbox for linux-iio@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: David Lechner <dlechner@baylibre.com>
Cc: "Michael Hennerich" <Michael.Hennerich@analog.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Jonathan Corbet" <corbet@lwn.net>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org
Subject: Re: [PATCH 0/4] iio: adc: ad4695: implement calibration support
Date: Mon, 26 Aug 2024 11:46:50 +0100	[thread overview]
Message-ID: <20240826114650.7c006113@jic23-huawei> (raw)
In-Reply-To: <20240820-ad4695-gain-offset-v1-0-c8f6e3b47551@baylibre.com>

On Tue, 20 Aug 2024 10:58:34 -0500
David Lechner <dlechner@baylibre.com> wrote:

> This series adds calibration support to the ad4695 driver.
> 
> This has the same "odd" gain and offset registers that are being used
> for calibration as discussed recently in the ad4030 series [1]. So if
> the ranges in the *_available attributes seem a bit big for calibration,
> that is why. The official datasheet explanation for this feature is,
> "The AD4695/AD4696 include offset and gain error correction
> functionality to correct for first-order nonidealities in a full
> [analog front end] signal chain."
> 
> [1]: https://lore.kernel.org/linux-iio/20240814193814.78fe45cc@jic23-huawei/
Series LGTM
Applied to the togreg branch of iio.git and pushed out as testing.
Note I'll be rebasing after the previous pull request (hopefully)
gets picked up by Greg.

Jonathan

> 
> ---
> David Lechner (4):
>       iio: adc: ad4695: add 2nd regmap for 16-bit registers
>       iio: adc: ad4695: implement calibration support
>       doc: iio: ad4695: update for calibration support
>       iio: ABI: document ad4695 new attributes
> 
>  Documentation/ABI/testing/sysfs-bus-iio |   3 +
>  Documentation/iio/ad4695.rst            |   7 +-
>  drivers/iio/adc/ad4695.c                | 242 +++++++++++++++++++++++++++++---
>  3 files changed, 234 insertions(+), 18 deletions(-)
> ---
> base-commit: 0f718e10da81446df0909c9939dff2b77e3b4e95
> change-id: 20240819-ad4695-gain-offset-c748d7addf27
> 
> Best regards,


      parent reply	other threads:[~2024-08-26 10:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-20 15:58 [PATCH 0/4] iio: adc: ad4695: implement calibration support David Lechner
2024-08-20 15:58 ` [PATCH 1/4] iio: adc: ad4695: add 2nd regmap for 16-bit registers David Lechner
2024-08-20 15:58 ` [PATCH 2/4] iio: adc: ad4695: implement calibration support David Lechner
2024-08-21  4:21   ` kernel test robot
2024-08-26 10:57     ` Jonathan Cameron
2024-08-21 13:16   ` Jonathan Cameron
2024-08-21 16:12     ` David Lechner
2024-08-21 16:33       ` Jonathan Cameron
2024-08-20 15:58 ` [PATCH 3/4] doc: iio: ad4695: update for " David Lechner
2024-08-20 15:58 ` [PATCH 4/4] iio: ABI: document ad4695 new attributes David Lechner
2024-08-26 10:46 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240826114650.7c006113@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=corbet@lwn.net \
    --cc=dlechner@baylibre.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox