Re: [PATCH v4 2/2] iio: imu: smi240: imu driver

Krzysztof Kozlowski
2024-08-26T14:57:39Z

On 26/08/2024 16:05, Jianping.Shen@de.bosch.com wrote:
> From: Shen Jianping <Jianping.Shen@de.bosch.com>
>
> This patch adds the iio driver for bosch imu smi240. The smi240
> is a combined three axis angular rate and three axis acceleration
> sensor module with a measurement range of +/-300°/s and up to 16g.
> Smi240 does not support interrupt. A synchronous acc and gyro
> sampling can be triggered by setting the capture bit in spi read
> command.
>
> Implemented features:
> * raw data access for each axis through sysfs
> * tiggered buffer for continuous sampling
> * synchronous acc and gyro data from tiggered buffer
>

...

> +
> +static int smi240_spi_probe(struct spi_device *spi)
> +{
> + struct regmap *regmap;
> +
> + regmap = devm_regmap_init(&spi->dev, &smi240_regmap_bus, &spi->dev,
> + &smi240_regmap_config);
> + if (IS_ERR(regmap))
> + return dev_err_probe(&spi->dev, PTR_ERR(regmap),
> + "Failed to initialize SPI Regmap\n");
> +
> + return smi240_core_probe(&spi->dev, regmap);

If the device supports only SPI (according to first patch description),
this entire split between core-spi does not make any sense. Just merge
these files.

Best regards,
Krzysztof