Re: [PATCH v4 1/2] dt-bindings: iio: imu: smi240: devicetree binding

Krzysztof Kozlowski
2024-08-26T14:54:05Z

On 26/08/2024 16:05, Jianping.Shen@de.bosch.com wrote:
> From: Shen Jianping <Jianping.Shen@de.bosch.com>
>
> This patch adds devicetree binding for Bosch imu smi240.

Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

A nit, subject: drop second/last, redundant "devicetree bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
Instead: "add Bosch FULL NAME OF THE DEVICE"

> The smi240 is a combined three axis angular rate and
> three axis acceleration sensor module.
>
> * The smi240 requires VDD and VDDIO
> * Provides only spi interface.
> * Does not support interrupt.

I don't understand why you mention above. It does not support interrupt,
just like it does not support AXI bus, 500 GPIOs etc. It suggests you
speak about driver, not hardware.

Just describe what this device is - like first sentence.

With some improvements here:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---


This is an automated instruction, just in case, because many review tags
are being ignored. If you know the process, you can skip it (please do
not feel offended by me posting it here - no bad intentions intended).
If you do not know the process, here is a short explanation:

Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag. Tag is "received", when
provided in a message replied to you on the mailing list. Tools like b4
can help here. However, there's no need to repost patches *only* to add
the tags. The upstream maintainer will do that for tags received on the
version they apply.

https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577


Best regards,
Krzysztof