From: Jonathan Cameron <jic23@kernel.org>
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: mcp320x: Drop vendorless compatible strings
Date: Sat, 31 Aug 2024 11:47:56 +0100 [thread overview]
Message-ID: <20240831114756.38b459a1@jic23-huawei> (raw)
In-Reply-To: <20240826191728.1415189-1-robh@kernel.org>
On Mon, 26 Aug 2024 14:17:28 -0500
"Rob Herring (Arm)" <robh@kernel.org> wrote:
> The vendorless compatible strings are deprecated and weren't retained
> when the binding was converted to schema. As a result, they are listed
> as undocumented when running "make dt_compatible_check". Rather than add
> them back to the schema, let's just drop them as they are unnecessary.
> Furthermore, they are unnecessary as the SPI matching will strip the
> vendor prefix on compatible string and match that against the
> spi_device_id table.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Applied.
Thanks,
> ---
> drivers/iio/adc/mcp320x.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/drivers/iio/adc/mcp320x.c b/drivers/iio/adc/mcp320x.c
> index da1421bd7b62..57cff3772ebe 100644
> --- a/drivers/iio/adc/mcp320x.c
> +++ b/drivers/iio/adc/mcp320x.c
> @@ -459,16 +459,6 @@ static int mcp320x_probe(struct spi_device *spi)
> }
>
> static const struct of_device_id mcp320x_dt_ids[] = {
> - /* NOTE: The use of compatibles with no vendor prefix is deprecated. */
> - { .compatible = "mcp3001" },
> - { .compatible = "mcp3002" },
> - { .compatible = "mcp3004" },
> - { .compatible = "mcp3008" },
> - { .compatible = "mcp3201" },
> - { .compatible = "mcp3202" },
> - { .compatible = "mcp3204" },
> - { .compatible = "mcp3208" },
> - { .compatible = "mcp3301" },
> { .compatible = "microchip,mcp3001" },
> { .compatible = "microchip,mcp3002" },
> { .compatible = "microchip,mcp3004" },
prev parent reply other threads:[~2024-08-31 10:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 19:17 [PATCH] iio: adc: mcp320x: Drop vendorless compatible strings Rob Herring (Arm)
2024-08-31 10:47 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240831114756.38b459a1@jic23-huawei \
--to=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox