Re: [PATCH v5 5/7] dt-bindings: iio: pressure: bmp085: Add interrupts for BMP3xx and BMP5xx devices

Krzysztof Kozlowski
2024-09-03T06:34:26Z

On Mon, Sep 02, 2024 at 08:42:20PM +0200, Vasileios Amoiridis wrote:
> Add interrupt options for BMP3xx and BMP5xx devices as well.
>
> Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
> ---
> .../bindings/iio/pressure/bmp085.yaml | 22 ++++++++++++++++++-
> 1 file changed, 21 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml b/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
> index 6fda887ee9d4..20b75865e02f 100644
> --- a/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
> +++ b/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
> @@ -48,14 +48,34 @@ properties:
>
> interrupts:
> description:
> - interrupt mapping for IRQ (BMP085 only)
> + interrupt mapping for IRQ. Supported in BMP085, BMP3xx, BMP5xx
> maxItems: 1
>
> + drive-open-drain:
> + description:
> + set if the interrupt pin should be configured as open drain.
> + If not set, defaults to push-pull configuration.
> + type: boolean
> +
> +

Just one blank liine.

> required:
> - compatible
> - vddd-supply
> - vdda-supply
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + not:
> + enum:
> + - bosch,bmp085
> + - bosch,bmp380
> + - bosch,bmp580

Are you sure you tested this patch?

Best regards,
Krzysztof