Re: [PATCH v5 7/7] iio: pressure: bmp280: Move bmp085 interrupt to new configuration

Andy Shevchenko
2024-09-03T14:39:54Z

On Mon, Sep 02, 2024 at 08:42:22PM +0200, Vasileios Amoiridis wrote:
> This commit intends to add the old BMP085 sensor to the new IRQ interface
> of the driver for consistence. No functional changes intended.
>
> The BMP085 sensor is equivalent with the BMP180 with the only difference of
> BMP085 having an extra interrupt pin to inform about an End of Conversion.

This one also LGTM,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

...

> - int ret;
> + int ret, irq;

I'm not fan of such a churn, meaning a new variable just on the new line to
make diff less noisy, but it's not a big deal at all.

--
With Best Regards,
Andy Shevchenko