Re: [PATCH v5 7/7] iio: pressure: bmp280: Move bmp085 interrupt to new configuration

Vasileios Amoiridis
2024-09-04T10:29:30Z

On Tue, Sep 03, 2024 at 05:39:47PM +0300, Andy Shevchenko wrote:
> On Mon, Sep 02, 2024 at 08:42:22PM +0200, Vasileios Amoiridis wrote:
> > This commit intends to add the old BMP085 sensor to the new IRQ interface
> > of the driver for consistence. No functional changes intended.
> >
> > The BMP085 sensor is equivalent with the BMP180 with the only difference of
> > BMP085 having an extra interrupt pin to inform about an End of Conversion.
>
> This one also LGTM,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>

Thanks a lot for this!

> ...
>
> > - int ret;
> > + int ret, irq;
>
> I'm not fan of such a churn, meaning a new variable just on the new line to
> make diff less noisy, but it's not a big deal at all.
>

I understand why, but at some point someone else would have come and make
a new commit probably with "organise/cleanup variable assignments"...

> --
> With Best Regards,
> Andy Shevchenko
>
>

Cheers,
Vasilis