From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3B00134B1; Sat, 7 Sep 2024 17:02:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725728562; cv=none; b=nqpnmYxu8UErcjCt5yl3GFe05sbfDMSKwh1TMdgvr/v9ZNf//kRb9dbvZYYUzgTX8hMTCafptCfqzhQYnYEdVKhQdv+9zUyBZgD09/CbyPbhGSFBc0Pg7WhmHrAK2tZz3bT2wK9tOd8PpFyyMKpq4eIoxJ0sssH6MM+SQPnNncQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725728562; c=relaxed/simple; bh=u6Mcf2G/UtDhfG9F19/02cvhzAL2moivAo5JbQWdUjU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=cC+JIekE61rXXDWikKT7i8YM6jWfSMvYlEPYYILYaUKc97//C3/RGDKtsUjkrbmNWFpfnKvBfRNMyC9sA5veFpWfPs0/sZvNtCCzQ7+qp5g4fPXAjo3PCcobSpnjkTvOXtqSVypCvbi8Hr6CM2gcD3JaFzCB6tX6qQP5IEx+H3o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=F3uACKrh; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="F3uACKrh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 15FC4C4CEC2; Sat, 7 Sep 2024 17:02:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725728561; bh=u6Mcf2G/UtDhfG9F19/02cvhzAL2moivAo5JbQWdUjU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=F3uACKrhN9GA5HX9E40MrYEd924Ekodalev4mok5di1o7m5+DRaoO6D/+J/hV4JkN tRQUI8ZYvNHma2fRx+xXksjV/WSS99VmX1+eib2P5TRwXJenDOOeYz1kbp42v07F05 dhFsa1kEx3KNbjJTIjKh7ifKOUGI5zrBGHeDBE7CLVgEpfeDzuRRBvegn4ZMqlhZ2Q ZUt2r7Dpr3ZVtpPDv3yRDDpFq8h2b8lM6LEjQdN1+mSQgcsjdXhziVpChE5xeRthSA x1NUUrm7+1mt1R43PvB/W41DPcLE8e6zgvxOQVLQEHzmUcURXIyssM3mVWVOU0Aco2 eyCtVpc7kBuMQ== Date: Sat, 7 Sep 2024 18:01:49 +0100 From: Jonathan Cameron To: Krzysztof Kozlowski Cc: Mariel Tinaco , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Michael Hennerich , Conor Dooley , Marcelo Schmitt , Dimitri Fedrau , David Lechner , Nuno =?UTF-8?B?U8Oh?= Subject: Re: [PATCH v3 1/2] dt-bindings: iio: dac: add docs for ad8460 Message-ID: <20240907180149.67fdc636@jic23-huawei> In-Reply-To: References: <20240904023040.23352-1-Mariel.Tinaco@analog.com> <20240904023040.23352-2-Mariel.Tinaco@analog.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 4 Sep 2024 08:20:53 +0200 Krzysztof Kozlowski wrote: > On Wed, Sep 04, 2024 at 10:30:39AM +0800, Mariel Tinaco wrote: > > This adds the bindings documentation for the 14-bit > > Please do not use "This commit/patch/change", but imperative mood. See > longer explanation here: > https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > > > High Voltage, High Current, Waveform Generator > > Digital-to-Analog converter. > > > > Signed-off-by: Mariel Tinaco > > --- > > .../bindings/iio/dac/adi,ad8460.yaml | 154 ++++++++++++++++++ > > MAINTAINERS | 7 + > > 2 files changed, 161 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/iio/dac/adi,ad8460.yaml > > > + adi,range-microvolt: > > + description: Voltage output range specified as > > + oneOf: > > This oneOf does not make sense. There is only one condition. Drop. > > > + - items: > > + - enum: [0, -10000000, -20000000, -30000000, -40000000, -55000000] > > + - enum: [10000000, 20000000, 30000000, 40000000, 55000000] > > What's the default? It's not a required property. > > > + > > + adi,range-microamp: > > + description: Current output range specified as > > + oneOf: > > + - items: > > + - enum: [-50000, -100000, -300000, -500000, -1000000] > > I don't understand why 0 is not listed here. I'm not sure why it is a list at all. Seems like the hardware allows a continuous value so this should just specify max and min. > > > + - enum: [50000, 100000, 300000, 500000, 1000000] > > + - items: > > + - const: 0 > > + - enum: [50000, 100000, 300000, 500000, 1000000] > > + > > What's the default? It's not a required property. > > > + adi,max-millicelsius: > > + description: Overtemperature threshold > > + default: 50000 > > + minimum: 20000 > > + maximum: 150000 > > + > > + shutdown-reset-gpios: > > + description: Corresponds to SDN_RESET pin. To exit shutdown > > + or sleep mode, pulse SDN_RESET HIGH, then leave LOW. > > + maxItems: 1 > > + > > + reset-gpios: > > + description: Manual Power On Reset (POR). Pull this GPIO pin > > + LOW and then HIGH to reset all digital registers to default > > + maxItems: 1 > > + > > + shutdown-gpios: > > + description: Corresponds to SDN_IO pin. Shutdown may be > > + initiated by the user, by pulsing SDN_IO high. To exit shutdown, > > + pulse SDN_IO low, then float. > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + - clocks > > Some supplies are for sure required. Devices rarely can operate without > power provided. > > > + > > +allOf: > > + - $ref: /schemas/spi/spi-peripheral-props.yaml# > > + > > +additionalProperties: false > > unevaluatedProperties instead. > > Best regards, > Krzysztof >