From: Vasileios Amoiridis <vassilisamir@gmail.com>
To: Vasileios Amoiridis <vassilisamir@gmail.com>
Cc: jic23@kernel.org, dan.carpenter@linaro.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: iio: pressure: bmp280: Use char instead of s32 for data buffer
Date: Wed, 11 Sep 2024 00:07:22 +0200 [thread overview]
Message-ID: <20240910220722.GD12725@vamoiridPC> (raw)
In-Reply-To: <20240823172017.9028-1-vassilisamir@gmail.com>
On Fri, Aug 23, 2024 at 07:20:17PM +0200, Vasileios Amoiridis wrote:
> As it was reported and discussed here [1], storing the sensor data in an
> endian aware s32 buffer is not optimal. Advertising the timestamp as an
> addition of 2 s32 variables which is also implied is again not the best
> practice. For that reason, change the s32 sensor_data buffer to a char
> buffer with an extra value for the timestamp (as it is common practice).
>
> [1]: https://lore.kernel.org/linux-iio/73d13cc0-afb9-4306-b498-5d821728c3ba@stanley.mountain/
>
> Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
> ---
> drivers/iio/pressure/bmp280-core.c | 43 +++++++++++++++++-------------
> drivers/iio/pressure/bmp280.h | 5 +++-
> 2 files changed, 28 insertions(+), 20 deletions(-)
>
Hi Jonathan,
I noticed that this patch didn't receive any comments nor applied.
Was this intentional because we wait for something from mainline to
be merged back?
Cheers,
Vasilis
next prev parent reply other threads:[~2024-09-10 22:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-23 17:20 iio: pressure: bmp280: Use char instead of s32 for data buffer Vasileios Amoiridis
2024-09-10 22:07 ` Vasileios Amoiridis [this message]
2024-09-14 11:36 ` Jonathan Cameron
2024-09-18 19:39 ` Vasileios Amoiridis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240910220722.GD12725@vamoiridPC \
--to=vassilisamir@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox