Re: [PATCH v6 2/4] dt-bindings: iio: pressure: bmp085: Add interrupts for BMP3xx and BMP5xx devices

Conor Dooley
2024-09-14T22:24:21Z

[-- Attachment #1: Type: text/plain, Size: 1545 bytes --]

On Sat, Sep 14, 2024 at 01:59:49AM +0200, Vasileios Amoiridis wrote:
> On Fri, Sep 13, 2024 at 07:27:29PM +0100, Conor Dooley wrote:
> > On Fri, Sep 13, 2024 at 01:32:32AM +0200, Vasileios Amoiridis wrote:
> > > Add interrupt options for BMP3xx and BMP5xx devices as well.
> > >
> > > Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
> > > ---
> > > .../bindings/iio/pressure/bmp085.yaml | 22 ++++++++++++++++++-
> > > 1 file changed, 21 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml b/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
> > > index 6fda887ee9d4..7c9d85be9008 100644
> > > --- a/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
> > > +++ b/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
> > > @@ -48,14 +48,34 @@ properties:
> > >
> > > interrupts:
> > > description:
> > > - interrupt mapping for IRQ (BMP085 only)
> > > + interrupt mapping for IRQ. Supported in BMP085, BMP3xx, BMP5xx
> >
> > If you respin, you can drop the description entirely, since you've added
> > proper enforcement below.
> >
> > Otherwise,
> > Acked-by: Conor Dooley <conor.dooley@microchip.com>
>
> Thanks for the time to review this, I will try to see if I can do it
> tonight, thanks!

I think I am "too late" in saying this, but I was not expecting a respin
for this change, but only for the change to be made if you were
respinning for another reason.

Thanks,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]