Re: [PATCH v6 2/4] dt-bindings: iio: pressure: bmp085: Add interrupts for BMP3xx and BMP5xx devices

Vasileios Amoiridis
2024-09-13T23:59:53Z

On Fri, Sep 13, 2024 at 07:27:29PM +0100, Conor Dooley wrote:
> On Fri, Sep 13, 2024 at 01:32:32AM +0200, Vasileios Amoiridis wrote:
> > Add interrupt options for BMP3xx and BMP5xx devices as well.
> >
> > Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
> > ---
> > .../bindings/iio/pressure/bmp085.yaml | 22 ++++++++++++++++++-
> > 1 file changed, 21 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml b/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
> > index 6fda887ee9d4..7c9d85be9008 100644
> > --- a/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
> > +++ b/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
> > @@ -48,14 +48,34 @@ properties:
> >
> > interrupts:
> > description:
> > - interrupt mapping for IRQ (BMP085 only)
> > + interrupt mapping for IRQ. Supported in BMP085, BMP3xx, BMP5xx
>
> If you respin, you can drop the description entirely, since you've added
> proper enforcement below.
>
> Otherwise,
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
>
> Cheers,
> Conor.
>

Hi Conor,

Thanks for the time to review this, I will try to see if I can do it
tonight, thanks!

Cheers,
Vasilis