From: Vasileios Amoiridis <vassilisamir@gmail.com>
To: Conor Dooley <conor@kernel.org>
Cc: Vasileios Amoiridis <vassilisamir@gmail.com>,
jic23@kernel.org, lars@metafoo.de, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
andriy.shevchenko@linux.intel.com, ang.iglesiasg@gmail.com,
linus.walleij@linaro.org, biju.das.jz@bp.renesas.com,
javier.carrasco.cruz@gmail.com, semen.protsenko@linaro.org,
579lpy@gmail.com, ak@it-klinger.de, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
christophe.jaillet@wanadoo.fr
Subject: Re: [PATCH v6 2/4] dt-bindings: iio: pressure: bmp085: Add interrupts for BMP3xx and BMP5xx devices
Date: Sat, 14 Sep 2024 01:59:49 +0200 [thread overview]
Message-ID: <20240913235949.GC33362@vamoiridPC> (raw)
In-Reply-To: <20240913-overarch-preplan-c899f16a90c8@spud>
On Fri, Sep 13, 2024 at 07:27:29PM +0100, Conor Dooley wrote:
> On Fri, Sep 13, 2024 at 01:32:32AM +0200, Vasileios Amoiridis wrote:
> > Add interrupt options for BMP3xx and BMP5xx devices as well.
> >
> > Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
> > ---
> > .../bindings/iio/pressure/bmp085.yaml | 22 ++++++++++++++++++-
> > 1 file changed, 21 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml b/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
> > index 6fda887ee9d4..7c9d85be9008 100644
> > --- a/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
> > +++ b/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
> > @@ -48,14 +48,34 @@ properties:
> >
> > interrupts:
> > description:
> > - interrupt mapping for IRQ (BMP085 only)
> > + interrupt mapping for IRQ. Supported in BMP085, BMP3xx, BMP5xx
>
> If you respin, you can drop the description entirely, since you've added
> proper enforcement below.
>
> Otherwise,
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
>
> Cheers,
> Conor.
>
Hi Conor,
Thanks for the time to review this, I will try to see if I can do it
tonight, thanks!
Cheers,
Vasilis
next prev parent reply other threads:[~2024-09-13 23:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-12 23:32 [PATCH v6 0/4] pressure: bmp280: Minor cleanup and interrupt support Vasileios Amoiridis
2024-09-12 23:32 ` [PATCH v6 1/4] iio: pressure: bmp280: Use sleep and forced mode for oneshot captures Vasileios Amoiridis
2024-09-13 9:51 ` Andy Shevchenko
2024-09-13 23:58 ` Vasileios Amoiridis
2024-09-12 23:32 ` [PATCH v6 2/4] dt-bindings: iio: pressure: bmp085: Add interrupts for BMP3xx and BMP5xx devices Vasileios Amoiridis
2024-09-13 18:27 ` Conor Dooley
2024-09-13 23:59 ` Vasileios Amoiridis [this message]
2024-09-14 22:24 ` Conor Dooley
2024-09-12 23:32 ` [PATCH v6 3/4] iio: pressure: bmp280: Add data ready trigger support Vasileios Amoiridis
2024-09-12 23:32 ` [PATCH v6 4/4] iio: pressure: bmp280: Move bmp085 interrupt to new configuration Vasileios Amoiridis
2024-09-13 9:54 ` [PATCH v6 0/4] pressure: bmp280: Minor cleanup and interrupt support Andy Shevchenko
2024-09-14 0:30 ` Vasileios Amoiridis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240913235949.GC33362@vamoiridPC \
--to=vassilisamir@gmail.com \
--cc=579lpy@gmail.com \
--cc=ak@it-klinger.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ang.iglesiasg@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=javier.carrasco.cruz@gmail.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=semen.protsenko@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox