From: Jonathan Cameron <jic23@kernel.org>
To: Abhash jha <abhashkumarjha123@gmail.com>
Cc: linux-iio@vger.kernel.org, anshulusr@gmail.com, lars@metafoo.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] iio: light: ltr390: Added configurable sampling frequency support
Date: Sat, 14 Sep 2024 18:33:13 +0100 [thread overview]
Message-ID: <20240914183313.05d4f7af@jic23-huawei> (raw)
In-Reply-To: <CAG=0RqL7y-Dmi6nAibkGOr32ufmMHS=pGjgp_7Er_oBTMqEszQ@mail.gmail.com>
On Sat, 14 Sep 2024 22:57:24 +0530
Abhash jha <abhashkumarjha123@gmail.com> wrote:
> > Hi Abhash,
> >
> > A few minor comments inline and an (optional) request to cleanup
> > the mask definitions in the existing code.
> > >
> > > #define LTR390_PART_NUMBER_ID 0xb
> > > #define LTR390_ALS_UVS_GAIN_MASK 0x07
> > > +#define LTR390_ALS_UVS_MEAS_RATE_MASK 0x07
> > These masks should be converted to GENMASK().
> > If you don't mind doing it a precursor patch to do so
> > would be nice to have.
> >
> Can I do the mask to GENMASK conversion in an additional cleanup patch
> at the end? The patch would clean up stuff related to newlines and such.
Doing it at the end is fine, but remember one patch per type of cleanup.
So if you have whitespace stuff and genmask, then two patches.
>
> Meanwhile I would use GENMASK for the new ones
Perfect. Thanks,
Jonathan
>
> Thanks,
> Abhash
next prev parent reply other threads:[~2024-09-14 17:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 4:50 [PATCH v2 0/4] Threshold event and Sampling freq support for LTR390 Abhash Jha
2024-09-10 4:50 ` [PATCH v2 1/4] iio: light: ltr390: Added configurable sampling frequency support Abhash Jha
2024-09-14 13:44 ` Jonathan Cameron
2024-09-14 17:27 ` Abhash jha
2024-09-14 17:33 ` Jonathan Cameron [this message]
2024-09-10 4:50 ` [PATCH v2 2/4] iio: light: ltr390: Suspend and Resume support Abhash Jha
2024-09-14 13:46 ` Jonathan Cameron
2024-09-10 4:50 ` [PATCH v2 3/4] iio: light: ltr390: Interrupts and threshold event support Abhash Jha
2024-09-14 13:53 ` Jonathan Cameron
2024-09-10 4:50 ` [PATCH v2 4/4] iio: light: ltr390: Add interrupt persistance support Abhash Jha
2024-09-14 13:54 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240914183313.05d4f7af@jic23-huawei \
--to=jic23@kernel.org \
--cc=abhashkumarjha123@gmail.com \
--cc=anshulusr@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox