Re: [PATCH 1/2] dt-bindings: iio: imu: mpu6050: Add iam20680ht/hp bindings to mpu6050

Jonathan Cameron
2024-09-28T15:56:01Z

On Fri, 20 Sep 2024 13:36:14 +0000
inv.git-commit@tdk.com wrote:

> From: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
>
> IAM-20680HT & HP are 2 variants of IAM-20680 fully compatible.
> They just have better specs, temperature range and a bigger FIFO.

Is that fifo size discoverable? If not then I'd describe
them as 'backwards compatible' but not 'fully' compatible.

So the binding is fine, as an aware driver would use the
more specific choice anyway and hence deal with that fifo
size change correctly. Someone who paid for this part
probably wants their bigger fifo.

Otherwise this looks fine to me as does the next patch.

Jonathan

>
> Signed-off-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
> ---
> .../devicetree/bindings/iio/imu/invensense,mpu6050.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml b/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml
> index 587ff2bced2d..a8d30ef015fa 100644
> --- a/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml
> +++ b/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml
> @@ -36,6 +36,11 @@ properties:
> - items:
> - const: invensense,icm20608d
> - const: invensense,icm20608
> + - items:
> + - enum:
> + - invensense,iam20680hp
> + - invensense,iam20680ht
> + - const: invensense,iam20680
>
> reg:
> maxItems: 1
> --
> 2.34.1
>