From: Jonathan Cameron <jic23@kernel.org>
To: Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@tdk.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: iio: imu: mpu6050: Add iam20680ht/hp bindings to mpu6050
Date: Mon, 30 Sep 2024 10:03:31 +0100 [thread overview]
Message-ID: <20240930100331.1e7573e0@jic23-huawei> (raw)
In-Reply-To: <FR3P281MB17575FC03AF60D690B67452CCE762@FR3P281MB1757.DEUP281.PROD.OUTLOOK.COM>
On Mon, 30 Sep 2024 08:46:05 +0000
Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@tdk.com> wrote:
> Hello Jonathan
>
> for the explanation, the chip variants at reset have a FIFO restricted to 512 bytes like the original one. You have to write specific bits in a register to unlock the FIFO to its full size.
>
> The driver is writing these bits only when you configure the variant. Otherwise, it will behave really like the original one.
>
> That's why I call them fully compatible.
Even then I'd go with 'backwards compatible'.
A driver that assumed the new device and tried to use that wouldn't work
with the IAM-20680 so it is one way compatibility.
The binding is fine, just the patch description may imply more than intended.
Jonathan
>
> Thanks,
> JB
>
> ________________________________________
> From: Jonathan Cameron <jic23@kernel.org>
> Sent: Saturday, September 28, 2024 18:45
> To: Krzysztof Kozlowski <krzk@kernel.org>
> Cc: Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@tdk.com>; Lars-Peter Clausen <lars@metafoo.de>; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@tdk.com>; linux-iio@vger.kernel.org <linux-iio@vger.kernel.org>; devicetree@vger.kernel.org <devicetree@vger.kernel.org>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>
> Subject: Re: [PATCH v2 1/2] dt-bindings: iio: imu: mpu6050: Add iam20680ht/hp bindings to mpu6050
>
> This Message Is From an External Sender
> This message came from outside your organization.
>
> On Mon, 23 Sep 2024 17:38:44 +0200
> Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> > On 23/09/2024 16:53, Jean-Baptiste Maneyrol via B4 Relay wrote:
> > > From: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
> > >
> > > IAM-20680HT & HP are 2 variants of IAM-20680 fully compatible.
> > > They just have better specs, temperature range and a bigger FIFO.
> > >
> > > Signed-off-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
> > > ---
> >
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Ah. I missed v2 as checked by email address.
>
> As per v1 review I've tweaked this patch description to say they are
> backwards compatible rather than fully (as the fifo size is not
> discoverable)
>
> Jonathan
>
> >
> > Best regards,
> > Krzysztof
> >
>
next prev parent reply other threads:[~2024-09-30 9:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-23 14:53 [PATCH v2 0/2] Add support of IAM-20680 HP & HT Jean-Baptiste Maneyrol via B4 Relay
2024-09-23 14:53 ` [PATCH v2 1/2] dt-bindings: iio: imu: mpu6050: Add iam20680ht/hp bindings to mpu6050 Jean-Baptiste Maneyrol via B4 Relay
2024-09-23 15:38 ` Krzysztof Kozlowski
2024-09-28 16:45 ` Jonathan Cameron
2024-09-30 8:46 ` Jean-Baptiste Maneyrol
2024-09-30 9:03 ` Jonathan Cameron [this message]
2024-09-23 14:53 ` [PATCH v2 2/2] iio: imu: inv_mpu6050: add support for IAM-20680HT/HP Jean-Baptiste Maneyrol via B4 Relay
2024-09-28 16:47 ` [PATCH v2 0/2] Add support of IAM-20680 HP & HT Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240930100331.1e7573e0@jic23-huawei \
--to=jic23@kernel.org \
--cc=Jean-Baptiste.Maneyrol@tdk.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).