[PATCH v2 0/2] Add support of IAM-20680 HP & HT

[PATCH v2 0/2] Add support of IAM-20680 HP & HT

[Jean-Baptiste Maneyrol via B4 Relay]

Add support of IAM-20680 HP & HT variants. These chips have better
hardware specs and a bigger FIFO while retaining full compatibility with
IAM-20680.

Changes for v2:
* Send patches to the correct list (devicetree was missing)

Signed-off-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
---
Jean-Baptiste Maneyrol (2):
      dt-bindings: iio: imu: mpu6050: Add iam20680ht/hp bindings to mpu6050
      iio: imu: inv_mpu6050: add support for IAM-20680HT/HP

 .../bindings/iio/imu/invensense,mpu6050.yaml         |  5 +++++
 drivers/iio/imu/inv_mpu6050/inv_mpu_core.c           | 20 ++++++++++++++++++++
 drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c            | 10 ++++++++++
 drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h            |  4 ++++
 drivers/iio/imu/inv_mpu6050/inv_mpu_spi.c            | 10 ++++++++++
 5 files changed, 49 insertions(+)
---
base-commit: 1504ee03b6e48187348d20f6efc74e7d93855728
change-id: 20240923-inv-mpu6050-add-iam20680-ht-hp-f5a42a96933b

Best regards,
-- 
Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>

[PATCH v2 1/2] dt-bindings: iio: imu: mpu6050: Add iam20680ht/hp bindings to mpu6050

[Jean-Baptiste Maneyrol via B4 Relay]

From: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>

IAM-20680HT & HP are 2 variants of IAM-20680 fully compatible.
They just have better specs, temperature range and a bigger FIFO.

Signed-off-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
---
 Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml b/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml
index 587ff2bced2ddd42e767f72b8e84c334d0e90481..a8d30ef015faaca02a11af7def6e06057bde3909 100644
--- a/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml
+++ b/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml
@@ -36,6 +36,11 @@ properties:
       - items:
           - const: invensense,icm20608d
           - const: invensense,icm20608
+      - items:
+          - enum:
+              - invensense,iam20680hp
+              - invensense,iam20680ht
+          - const: invensense,iam20680
 
   reg:
     maxItems: 1

-- 
2.34.1

Re: [PATCH v2 1/2] dt-bindings: iio: imu: mpu6050: Add iam20680ht/hp bindings to mpu6050

[Krzysztof Kozlowski]

On 23/09/2024 16:53, Jean-Baptiste Maneyrol via B4 Relay wrote:
> From: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
> 
> IAM-20680HT & HP are 2 variants of IAM-20680 fully compatible.
> They just have better specs, temperature range and a bigger FIFO.
> 
> Signed-off-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
> ---

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH v2 1/2] dt-bindings: iio: imu: mpu6050: Add iam20680ht/hp bindings to mpu6050

[Jonathan Cameron]

On Mon, 23 Sep 2024 17:38:44 +0200
Krzysztof Kozlowski <krzk@kernel.org> wrote:

> On 23/09/2024 16:53, Jean-Baptiste Maneyrol via B4 Relay wrote:
> > From: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
> > 
> > IAM-20680HT & HP are 2 variants of IAM-20680 fully compatible.
> > They just have better specs, temperature range and a bigger FIFO.
> > 
> > Signed-off-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
> > ---  
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Ah. I missed v2 as checked by email address.

As per v1 review I've tweaked this patch description to say they are
backwards compatible rather than fully (as the fifo size is not
discoverable)

Jonathan

> 
> Best regards,
> Krzysztof
> 

Re: [PATCH v2 1/2] dt-bindings: iio: imu: mpu6050: Add iam20680ht/hp bindings to mpu6050

[Jean-Baptiste Maneyrol]

Hello Jonathan

for the explanation, the chip variants at reset have a FIFO restricted to 512 bytes like the original one. You have to write specific bits in a register to unlock the FIFO to its full size.

The driver is writing these bits only when you configure the variant. Otherwise, it will behave really like the original one.

That's why I call them fully compatible.

Thanks,
JB

________________________________________
From: Jonathan Cameron <jic23@kernel.org>
Sent: Saturday, September 28, 2024 18:45
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@tdk.com>; Lars-Peter Clausen <lars@metafoo.de>; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@tdk.com>; linux-iio@vger.kernel.org <linux-iio@vger.kernel.org>; devicetree@vger.kernel.org <devicetree@vger.kernel.org>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: iio: imu: mpu6050: Add iam20680ht/hp bindings to mpu6050
 
This Message Is From an External Sender
This message came from outside your organization.
 
On Mon, 23 Sep 2024 17:38:44 +0200
Krzysztof Kozlowski <krzk@kernel.org> wrote:

> On 23/09/2024 16:53, Jean-Baptiste Maneyrol via B4 Relay wrote:
> > From: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
> > 
> > IAM-20680HT & HP are 2 variants of IAM-20680 fully compatible.
> > They just have better specs, temperature range and a bigger FIFO.
> > 
> > Signed-off-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
> > ---  
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Ah. I missed v2 as checked by email address.

As per v1 review I've tweaked this patch description to say they are
backwards compatible rather than fully (as the fifo size is not
discoverable)

Jonathan

> 
> Best regards,
> Krzysztof
> 

Re: [PATCH v2 1/2] dt-bindings: iio: imu: mpu6050: Add iam20680ht/hp bindings to mpu6050

[Jonathan Cameron]

On Mon, 30 Sep 2024 08:46:05 +0000
Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@tdk.com> wrote:

> Hello Jonathan
> 
> for the explanation, the chip variants at reset have a FIFO restricted to 512 bytes like the original one. You have to write specific bits in a register to unlock the FIFO to its full size.
> 
> The driver is writing these bits only when you configure the variant. Otherwise, it will behave really like the original one.
> 
> That's why I call them fully compatible.
Even then I'd go with 'backwards compatible'.

A driver that assumed the new device and tried to use that wouldn't work
with the IAM-20680 so it is one way compatibility.

The binding is fine, just the patch description may imply more than intended.

Jonathan

> 
> Thanks,
> JB
> 
> ________________________________________
> From: Jonathan Cameron <jic23@kernel.org>
> Sent: Saturday, September 28, 2024 18:45
> To: Krzysztof Kozlowski <krzk@kernel.org>
> Cc: Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@tdk.com>; Lars-Peter Clausen <lars@metafoo.de>; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@tdk.com>; linux-iio@vger.kernel.org <linux-iio@vger.kernel.org>; devicetree@vger.kernel.org <devicetree@vger.kernel.org>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>
> Subject: Re: [PATCH v2 1/2] dt-bindings: iio: imu: mpu6050: Add iam20680ht/hp bindings to mpu6050
>  
> This Message Is From an External Sender
> This message came from outside your organization.
>  
> On Mon, 23 Sep 2024 17:38:44 +0200
> Krzysztof Kozlowski <krzk@kernel.org> wrote:
> 
> > On 23/09/2024 16:53, Jean-Baptiste Maneyrol via B4 Relay wrote:  
> > > From: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
> > > 
> > > IAM-20680HT & HP are 2 variants of IAM-20680 fully compatible.
> > > They just have better specs, temperature range and a bigger FIFO.
> > > 
> > > Signed-off-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
> > > ---    
> > 
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>  
> Ah. I missed v2 as checked by email address.
> 
> As per v1 review I've tweaked this patch description to say they are
> backwards compatible rather than fully (as the fifo size is not
> discoverable)
> 
> Jonathan
> 
> > 
> > Best regards,
> > Krzysztof
> >   
> 

[PATCH v2 2/2] iio: imu: inv_mpu6050: add support for IAM-20680HT/HP

[Jean-Baptiste Maneyrol via B4 Relay]

From: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>

IAM-20680HT & HP are 2 variants of IAM-20680 with better specs,
wider temperature range, and a bigger FIFO (4k).

Fully compatible with IAM-20680, FIFO is 512 bytes by default and
with correct register setting we expand it to full 4k.

Signed-off-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
---
 drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 20 ++++++++++++++++++++
 drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c  | 10 ++++++++++
 drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h  |  4 ++++
 drivers/iio/imu/inv_mpu6050/inv_mpu_spi.c  | 10 ++++++++++
 4 files changed, 44 insertions(+)

diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
index 14d95f34e981c8b71dd0892fbeb12735a8857d6c..6b0adb7f9ae301878d9b4d6febec0309bd77a256 100644
--- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
+++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
@@ -286,6 +286,24 @@ static const struct inv_mpu6050_hw hw_info[] = {
 		.temp = {INV_ICM20608_TEMP_OFFSET, INV_ICM20608_TEMP_SCALE},
 		.startup_time = {INV_MPU6500_GYRO_STARTUP_TIME, INV_MPU6500_ACCEL_STARTUP_TIME},
 	},
+	{
+		.whoami = INV_IAM20680HP_WHOAMI_VALUE,
+		.name = "IAM20680HP",
+		.reg = &reg_set_6500,
+		.config = &chip_config_6500,
+		.fifo_size = 4 * 1024,
+		.temp = {INV_ICM20608_TEMP_OFFSET, INV_ICM20608_TEMP_SCALE},
+		.startup_time = {INV_MPU6500_GYRO_STARTUP_TIME, INV_MPU6500_ACCEL_STARTUP_TIME},
+	},
+	{
+		.whoami = INV_IAM20680HT_WHOAMI_VALUE,
+		.name = "IAM20680HT",
+		.reg = &reg_set_6500,
+		.config = &chip_config_6500,
+		.fifo_size = 4 * 1024,
+		.temp = {INV_ICM20608_TEMP_OFFSET, INV_ICM20608_TEMP_SCALE},
+		.startup_time = {INV_MPU6500_GYRO_STARTUP_TIME, INV_MPU6500_ACCEL_STARTUP_TIME},
+	},
 };
 
 static int inv_mpu6050_pwr_mgmt_1_write(struct inv_mpu6050_state *st, bool sleep,
@@ -510,6 +528,8 @@ static int inv_mpu6050_set_accel_lpf_regs(struct inv_mpu6050_state *st,
 		return 0;
 	case INV_ICM20689:
 	case INV_ICM20690:
+	case INV_IAM20680HT:
+	case INV_IAM20680HP:
 		/* set FIFO size to maximum value */
 		val |= INV_ICM20689_BITS_FIFO_SIZE_MAX;
 		break;
diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c
index 0e03137fb3d40d4753989522cf5168ef358a1014..7a5926ba6b97d5e5fbdd08e0c90b58afb3f0131a 100644
--- a/drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c
+++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c
@@ -188,6 +188,8 @@ static const struct i2c_device_id inv_mpu_id[] = {
 	{"icm20602", INV_ICM20602},
 	{"icm20690", INV_ICM20690},
 	{"iam20680", INV_IAM20680},
+	{"iam20680hp", INV_IAM20680HP},
+	{"iam20680ht", INV_IAM20680HT},
 	{}
 };
 
@@ -254,6 +256,14 @@ static const struct of_device_id inv_of_match[] = {
 		.compatible = "invensense,iam20680",
 		.data = (void *)INV_IAM20680
 	},
+	{
+		.compatible = "invensense,iam20680hp",
+		.data = (void *)INV_IAM20680HP
+	},
+	{
+		.compatible = "invensense,iam20680ht",
+		.data = (void *)INV_IAM20680HT
+	},
 	{ }
 };
 MODULE_DEVICE_TABLE(of, inv_of_match);
diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h b/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h
index e1c0c51468761ab18188a224e44e09f919d81f9a..a6862cf426396cbaf3452bb3451cd58e4f30a4ec 100644
--- a/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h
+++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h
@@ -85,6 +85,8 @@ enum inv_devices {
 	INV_ICM20602,
 	INV_ICM20690,
 	INV_IAM20680,
+	INV_IAM20680HP,
+	INV_IAM20680HT,
 	INV_NUM_PARTS
 };
 
@@ -424,6 +426,8 @@ struct inv_mpu6050_state {
 #define INV_ICM20602_WHOAMI_VALUE		0x12
 #define INV_ICM20690_WHOAMI_VALUE		0x20
 #define INV_IAM20680_WHOAMI_VALUE		0xA9
+#define INV_IAM20680HP_WHOAMI_VALUE		0xF8
+#define INV_IAM20680HT_WHOAMI_VALUE		0xFA
 
 /* scan element definition for generic MPU6xxx devices */
 enum inv_mpu6050_scan {
diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_spi.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_spi.c
index 05451ca1580b637a66a30efe82fbd2a2b63e55d5..e6a291fcda958c56e889e58151929a2f602b0426 100644
--- a/drivers/iio/imu/inv_mpu6050/inv_mpu_spi.c
+++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_spi.c
@@ -80,6 +80,8 @@ static const struct spi_device_id inv_mpu_id[] = {
 	{"icm20602", INV_ICM20602},
 	{"icm20690", INV_ICM20690},
 	{"iam20680", INV_IAM20680},
+	{"iam20680hp", INV_IAM20680HP},
+	{"iam20680ht", INV_IAM20680HT},
 	{}
 };
 
@@ -142,6 +144,14 @@ static const struct of_device_id inv_of_match[] = {
 		.compatible = "invensense,iam20680",
 		.data = (void *)INV_IAM20680
 	},
+	{
+		.compatible = "invensense,iam20680hp",
+		.data = (void *)INV_IAM20680HP
+	},
+	{
+		.compatible = "invensense,iam20680ht",
+		.data = (void *)INV_IAM20680HT
+	},
 	{ }
 };
 MODULE_DEVICE_TABLE(of, inv_of_match);

-- 
2.34.1

Re: [PATCH v2 0/2] Add support of IAM-20680 HP & HT

[Jonathan Cameron]

On Mon, 23 Sep 2024 16:53:20 +0200
Jean-Baptiste Maneyrol via B4 Relay <devnull+jean-baptiste.maneyrol.tdk.com@kernel.org> wrote:

> Add support of IAM-20680 HP & HT variants. These chips have better
> hardware specs and a bigger FIFO while retaining full compatibility with
> IAM-20680.
> 
> Changes for v2:
> * Send patches to the correct list (devicetree was missing)
> 
> Signed-off-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
Series applied to the testing branch of iio.git which I will rebase once
rc1 is available.

Thanks,

Jonathan

> ---
> Jean-Baptiste Maneyrol (2):
>       dt-bindings: iio: imu: mpu6050: Add iam20680ht/hp bindings to mpu6050
>       iio: imu: inv_mpu6050: add support for IAM-20680HT/HP
> 
>  .../bindings/iio/imu/invensense,mpu6050.yaml         |  5 +++++
>  drivers/iio/imu/inv_mpu6050/inv_mpu_core.c           | 20 ++++++++++++++++++++
>  drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c            | 10 ++++++++++
>  drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h            |  4 ++++
>  drivers/iio/imu/inv_mpu6050/inv_mpu_spi.c            | 10 ++++++++++
>  5 files changed, 49 insertions(+)
> ---
> base-commit: 1504ee03b6e48187348d20f6efc74e7d93855728
> change-id: 20240923-inv-mpu6050-add-iam20680-ht-hp-f5a42a96933b
> 
> Best regards,