From: Jonathan Cameron <jic23@kernel.org>
To: Abhash jha <abhashkumarjha123@gmail.com>
Cc: linux-iio@vger.kernel.org, lars@metafoo.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] iio: light: vl6180: Add configurable inter-measurement period support
Date: Sat, 5 Oct 2024 18:03:19 +0100 [thread overview]
Message-ID: <20241005180319.2c9e8eab@jic23-huawei> (raw)
In-Reply-To: <CAG=0RqKM8HJ-rV54mCjo1-J6FOsed8zoHSWaVJ1YErSNNZDX1w@mail.gmail.com>
On Sat, 5 Oct 2024 22:26:09 +0530
Abhash jha <abhashkumarjha123@gmail.com> wrote:
> > Hi Abhash,
> >
> > Sampling frequency must be in Hz and reflect how often the channel
> > is sampled (not just the inter measurement period. So this sounds wrong.
> > It is sometimes complex to compute but we have to stick to the documented
> > ABI.
> Got it. I thought of skipping out the complex computation in the
> driver and assumed
> the user would give me pre-computed ms values.
>
> Just one thing, Is it better to just use IIO_CHAN_INFO_SAMP_FREQ for
> "inter-measurement period"
> and get the input in HZ (converting HZ to ms in driver)
This one.
> Or
> Define a custom sysfs attribute like `inter_measurement_period` to get
> ms values? for this driver.
Always best to avoid custom attributes where at all possible because
standard userspace has no way to know how to use them.
Jonathan
>
> Thanks,
> Abhash
next prev parent reply other threads:[~2024-10-05 17:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 15:01 [PATCH 0/3] Interrupt and Continuous mode support for VL6180 Abhash Jha
2024-10-04 15:01 ` [PATCH 1/3] iio: light: vl6180: Add configurable inter-measurement period support Abhash Jha
2024-10-05 12:25 ` kernel test robot
2024-10-05 16:41 ` Jonathan Cameron
2024-10-05 16:56 ` Abhash jha
2024-10-05 17:03 ` Jonathan Cameron [this message]
2024-10-04 15:01 ` [PATCH 2/3] iio: light: vl6180: Added Interrupt support for single shot access Abhash Jha
2024-10-05 16:47 ` Jonathan Cameron
2024-10-05 17:35 ` Abhash jha
2024-10-05 18:08 ` Jonathan Cameron
2024-10-04 15:01 ` [PATCH 3/3] iio: light: vl6180: Add support for Continuous Mode Abhash Jha
2024-10-05 16:59 ` Jonathan Cameron
2024-10-05 17:12 ` Abhash jha
2024-10-05 18:15 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241005180319.2c9e8eab@jic23-huawei \
--to=jic23@kernel.org \
--cc=abhashkumarjha123@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox