From: Jonathan Cameron <jic23@kernel.org>
To: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Cc: "Lars-Peter Clausen" <lars@metafoo.de>,
"Matti Vaittinen" <mazziesaccount@gmail.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sa" <nuno.sa@analog.com>, "Dan Murphy" <dmurphy@ti.com>,
"Sean Nyekjaer" <sean@geanix.com>,
"Leonard Göhrs" <l.goehrs@pengutronix.de>,
"Mihail Chindris" <mihail.chindris@analog.com>,
"Alexandru Ardelean" <ardeleanalex@gmail.com>,
"Gustavo Silva" <gustavograzs@gmail.com>,
"Shoji Keita" <awaittrot@shjk.jp>,
"Andrey Skvortsov" <andrej.skvortzov@gmail.com>,
"Dalton Durst" <dalton@ubports.com>,
"Icenowy Zheng" <icenowy@aosc.io>,
"Andreas Klinger" <ak@it-klinger.de>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"Ondrej Jirman" <megi@xff.cz>
Subject: Re: [PATCH 12/13] iio: pressure: bu1390: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig
Date: Sat, 5 Oct 2024 19:01:47 +0100 [thread overview]
Message-ID: <20241005190147.084dd468@jic23-huawei> (raw)
In-Reply-To: <20241003-iio-select-v1-12-67c0385197cd@gmail.com>
On Thu, 03 Oct 2024 23:04:58 +0200
Javier Carrasco <javier.carrasco.cruz@gmail.com> wrote:
> This driver makes use of triggered buffers, but does not select the
> required modules.
>
> Add the missing 'select IIO_BUFFER' and 'select IIO_TRIGGERED_BUFFER'.
>
> Fixes: 81ca5979b6ed ("iio: pressure: Support ROHM BU1390")
Seems unlikely in the bm1390 driver. Huh. It is accurate, but I'll fix the
patch description to refer to the bm1390 which seems to be the right
name and add a note on this as it looks suspect otherwise.
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
> ---
> drivers/iio/pressure/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/iio/pressure/Kconfig b/drivers/iio/pressure/Kconfig
> index df65438c771e..d2cb8c871f6a 100644
> --- a/drivers/iio/pressure/Kconfig
> +++ b/drivers/iio/pressure/Kconfig
> @@ -19,6 +19,9 @@ config ABP060MG
> config ROHM_BM1390
> tristate "ROHM BM1390GLV-Z pressure sensor driver"
> depends on I2C
> + select REGMAP_I2C
> + select IIO_BUFFER
> + select IIO_TRIGGERED_BUFFER
> help
> Support for the ROHM BM1390 pressure sensor. The BM1390GLV-Z
> can measure pressures ranging from 300 hPa to 1300 hPa with
>
next prev parent reply other threads:[~2024-10-05 18:02 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-03 21:04 [PATCH 00/13] iio: add missing select REMAP_SPI, IIO_BUFFER, and IIO_TRIGGERED_BUFFER Javier Carrasco
2024-10-03 21:04 ` [PATCH 01/13] iio: accel: kx022a: add missing select IIO_(TRIGGERED_)BUFFER in Kconfig Javier Carrasco
2024-10-04 8:17 ` Matti Vaittinen
2024-10-05 17:47 ` Jonathan Cameron
2024-10-03 21:04 ` [PATCH 02/13] iio: adc: ad7944: " Javier Carrasco
2024-10-03 23:00 ` David Lechner
2024-10-05 17:48 ` Jonathan Cameron
2024-10-03 21:04 ` [PATCH 03/13] iio: adc: ti-ads124s08: " Javier Carrasco
2024-10-03 21:04 ` [PATCH 04/13] iio: adc: ti-ads8688: " Javier Carrasco
2024-10-04 6:40 ` Sean Nyekjaer
2024-10-05 17:40 ` Jonathan Cameron
2024-10-05 18:21 ` Javier Carrasco
2024-10-10 18:00 ` Jonathan Cameron
2024-10-03 21:04 ` [PATCH 05/13] iio: adc: ti-lmp92064: add missing select REGMAP_SPI " Javier Carrasco
2024-10-05 17:50 ` Jonathan Cameron
2024-10-03 21:04 ` [PATCH 06/13] iio: adc: ti-lmp92064: add missing select IIO_(TRIGGERED_)BUFFER " Javier Carrasco
2024-10-05 17:51 ` Jonathan Cameron
2024-10-03 21:04 ` [PATCH 07/13] iio: dac: ad3552r: " Javier Carrasco
2024-10-05 17:52 ` Jonathan Cameron
2024-10-03 21:04 ` [PATCH 08/13] iio: dac: ad5766: " Javier Carrasco
2024-10-05 17:53 ` Jonathan Cameron
2024-10-03 21:04 ` [PATCH 09/13] iio: chemical: ens160: " Javier Carrasco
2024-10-04 14:27 ` Gustavo Silva
2024-10-05 17:54 ` Jonathan Cameron
2024-10-03 21:04 ` [PATCH 10/13] iio: light: bu27008: " Javier Carrasco
2024-10-04 8:16 ` Matti Vaittinen
2024-10-05 17:56 ` Jonathan Cameron
2024-10-03 21:04 ` [PATCH 11/13] iio: magnetometer: af8133j: " Javier Carrasco
2024-10-04 8:58 ` Andrey Skvortsov
2024-10-05 17:57 ` Jonathan Cameron
2024-10-03 21:04 ` [PATCH 12/13] iio: pressure: bu1390: " Javier Carrasco
2024-10-04 8:16 ` Matti Vaittinen
2024-10-05 18:01 ` Jonathan Cameron [this message]
2024-10-05 18:12 ` Javier Carrasco
2024-10-06 11:13 ` Matti Vaittinen
2024-10-10 13:46 ` Andy Shevchenko
2024-10-10 17:54 ` Jonathan Cameron
2024-10-03 21:04 ` [PATCH 13/13] iio: proximity: mb1232: " Javier Carrasco
2024-10-05 18:03 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241005190147.084dd468@jic23-huawei \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=ak@it-klinger.de \
--cc=andrej.skvortzov@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ardeleanalex@gmail.com \
--cc=awaittrot@shjk.jp \
--cc=dalton@ubports.com \
--cc=dlechner@baylibre.com \
--cc=dmurphy@ti.com \
--cc=gustavograzs@gmail.com \
--cc=icenowy@aosc.io \
--cc=javier.carrasco.cruz@gmail.com \
--cc=l.goehrs@pengutronix.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=megi@xff.cz \
--cc=mihail.chindris@analog.com \
--cc=nuno.sa@analog.com \
--cc=sean@geanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).