* [PATCH v2] iio: gts-helper: Fix memory leaks for the error path of iio_gts_build_avail_scale_table()
@ 2024-10-16 1:24 Jinjie Ruan
2024-10-19 14:10 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Jinjie Ruan @ 2024-10-16 1:24 UTC (permalink / raw)
To: mazziesaccount, jic23, lars, linux-iio, linux-kernel; +Cc: ruanjinjie
If per_time_scales[i] or per_time_gains[i] kcalloc fails in the for loop
of iio_gts_build_avail_scale_table(), the err_free_out will fail to call
kfree() each time when i is reduced to 0, so all the per_time_scales[0]
and per_time_gains[0] will not be freed, which will cause memory leaks.
Fix it by checking if i >= 0.
Cc: stable@vger.kernel.org
Fixes: 38416c28e168 ("iio: light: Add gain-time-scale helpers")
Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com>
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
---
v2:
- Update the commit message.
- Add Reviewed-by.
---
drivers/iio/industrialio-gts-helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/industrialio-gts-helper.c b/drivers/iio/industrialio-gts-helper.c
index 7326c7949244..5f131bc1a01e 100644
--- a/drivers/iio/industrialio-gts-helper.c
+++ b/drivers/iio/industrialio-gts-helper.c
@@ -315,7 +315,7 @@ static int iio_gts_build_avail_scale_table(struct iio_gts *gts)
return 0;
err_free_out:
- for (i--; i; i--) {
+ for (i--; i >= 0; i--) {
kfree(per_time_scales[i]);
kfree(per_time_gains[i]);
}
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] iio: gts-helper: Fix memory leaks for the error path of iio_gts_build_avail_scale_table()
2024-10-16 1:24 [PATCH v2] iio: gts-helper: Fix memory leaks for the error path of iio_gts_build_avail_scale_table() Jinjie Ruan
@ 2024-10-19 14:10 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2024-10-19 14:10 UTC (permalink / raw)
To: Jinjie Ruan; +Cc: mazziesaccount, lars, linux-iio, linux-kernel
On Wed, 16 Oct 2024 09:24:53 +0800
Jinjie Ruan <ruanjinjie@huawei.com> wrote:
> If per_time_scales[i] or per_time_gains[i] kcalloc fails in the for loop
> of iio_gts_build_avail_scale_table(), the err_free_out will fail to call
> kfree() each time when i is reduced to 0, so all the per_time_scales[0]
> and per_time_gains[0] will not be freed, which will cause memory leaks.
>
> Fix it by checking if i >= 0.
>
> Cc: stable@vger.kernel.org
> Fixes: 38416c28e168 ("iio: light: Add gain-time-scale helpers")
> Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Applied.
> ---
> v2:
> - Update the commit message.
> - Add Reviewed-by.
> ---
> drivers/iio/industrialio-gts-helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/industrialio-gts-helper.c b/drivers/iio/industrialio-gts-helper.c
> index 7326c7949244..5f131bc1a01e 100644
> --- a/drivers/iio/industrialio-gts-helper.c
> +++ b/drivers/iio/industrialio-gts-helper.c
> @@ -315,7 +315,7 @@ static int iio_gts_build_avail_scale_table(struct iio_gts *gts)
> return 0;
>
> err_free_out:
> - for (i--; i; i--) {
> + for (i--; i >= 0; i--) {
> kfree(per_time_scales[i]);
> kfree(per_time_gains[i]);
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-19 14:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-16 1:24 [PATCH v2] iio: gts-helper: Fix memory leaks for the error path of iio_gts_build_avail_scale_table() Jinjie Ruan
2024-10-19 14:10 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).