Re: [PATCH v3 02/24] iio: adc: pac1934: Replace strange way of checking type of enumeration

Jonathan Cameron
2024-10-26T11:04:00Z

On Thu, 24 Oct 2024 22:04:51 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> When device is enumerated via ACPI the respective device node is of
> ACPI device type. Use that to check for ACPI enumeration, rather than
> calling for full match which is O(n) vs. O(1) for the regular check.
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> Reviewed-by: Marius Cristea <marius.cristea@microchip.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Applied
> ---
> drivers/iio/adc/pac1934.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/pac1934.c b/drivers/iio/adc/pac1934.c
> index 7ef249d83286..20802b7f49ea 100644
> --- a/drivers/iio/adc/pac1934.c
> +++ b/drivers/iio/adc/pac1934.c
> @@ -1507,7 +1507,7 @@ static int pac1934_probe(struct i2c_client *client)
> indio_dev->name = pac1934_chip_config[ret].name;
> }
>
> - if (acpi_match_device(dev->driver->acpi_match_table, dev))
> + if (is_acpi_device_node(dev_fwnode(dev)))
> ret = pac1934_acpi_parse_channel_config(client, info);
> else
> /*