public inbox for linux-iio@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: David Lechner <dlechner@baylibre.com>
Cc: "Angelo Dureghello" <adureghello@baylibre.com>,
	"Nuno Sá" <noname.nuno@gmail.com>, "Nuno Sá" <nuno.sa@analog.com>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Michael Hennerich" <Michael.Hennerich@analog.com>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Olivier Moysan" <olivier.moysan@foss.st.com>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, "Mark Brown" <broonie@kernel.org>
Subject: Re: [PATCH v7 7/8] iio: dac: ad3552r: add high-speed platform driver
Date: Sat, 26 Oct 2024 18:35:02 +0100	[thread overview]
Message-ID: <20241026183502.40662850@jic23-huawei> (raw)
In-Reply-To: <f70854c2-8006-4278-b149-6d8c3e76b30d@baylibre.com>

On Thu, 24 Oct 2024 10:13:25 -0500
David Lechner <dlechner@baylibre.com> wrote:

> On 10/24/24 10:02 AM, Angelo Dureghello wrote:
> > Hi Nuno,
> > 
> > On 24.10.2024 15:05, Nuno Sá wrote:  
> >> On Tue, 2024-10-22 at 18:40 +0200, Angelo Dureghello wrote:  
> >>> Hi Nuno,
> >>>
> >>> On 22.10.2024 14:28, Nuno Sá wrote:  
> >>>> On Mon, 2024-10-21 at 14:40 +0200, Angelo Dureghello wrote:  
> >>>>> From: Angelo Dureghello <adureghello@baylibre.com>
> >>>>>
> >>>>> Add High Speed ad3552r platform driver.  
> 
> ...
> 
> >>>>> +	switch (mask) {
> >>>>> +	case IIO_CHAN_INFO_RAW:
> >>>>> +		iio_device_claim_direct_scoped(return -EBUSY, indio_dev) {
> >>>>> +			return st->data->bus_reg_write(st->back,
> >>>>> +				    AD3552R_REG_ADDR_CH_DAC_16B(chan-  
> >>>>>> channel),  
> >>>>> +				    val, 2);
> >>>>> +		}  
> >>>>
> >>>> Maybe we'll get the new stuff in time for this :)
> >>>>  
> > This is not clear, sorry.
> >   
> 
> Probably this :-)
> 
> https://lore.kernel.org/all/20241023105757.GA9767@noisy.programming.kicks-ass.net/
> 
> But it hasn't reached the stable tree yet.

Agreed. It is going to be nice to get rid of so much ugly code.
I guess mostly next cycle however.

Jonathan

  reply	other threads:[~2024-10-26 17:35 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-21 12:40 [PATCH v7 0/8] iio: add support for the ad3552r AXI DAC IP Angelo Dureghello
2024-10-21 12:40 ` [PATCH v7 1/8] dt-bindings: iio: dac: ad3552r: add iio backend support Angelo Dureghello
2024-10-21 12:40 ` [PATCH v7 2/8] dt-bindings: iio: dac: adi-axi-dac: add ad3552r axi variant Angelo Dureghello
2024-10-22 17:22   ` Conor Dooley
2024-10-24  9:28     ` Angelo Dureghello
2024-10-24 12:37       ` Nuno Sá
2024-10-24 14:43         ` David Lechner
2024-10-24 16:45           ` Conor Dooley
2024-10-21 12:40 ` [PATCH v7 3/8] iio: backend: extend features Angelo Dureghello
2024-10-21 12:40 ` [PATCH v7 4/8] iio: dac: adi-axi-dac: " Angelo Dureghello
2024-10-22 12:36   ` Nuno Sá
2024-10-22 17:21     ` Conor Dooley
2024-10-23 14:56       ` Nuno Sá
2024-10-23 15:22         ` Conor Dooley
2024-10-24  7:04           ` Nuno Sá
2024-10-24 10:29             ` Angelo Dureghello
2024-10-26 17:31               ` Jonathan Cameron
2024-10-21 12:40 ` [PATCH v7 5/8] iio: dac: ad3552r: changes to use FIELD_PREP Angelo Dureghello
2024-10-21 12:40 ` [PATCH v7 6/8] iio: dac: ad3552r: extract common code (no changes in behavior intended) Angelo Dureghello
2024-10-21 12:40 ` [PATCH v7 7/8] iio: dac: ad3552r: add high-speed platform driver Angelo Dureghello
2024-10-22 12:28   ` Nuno Sá
2024-10-22 16:40     ` Angelo Dureghello
2024-10-24 13:05       ` Nuno Sá
2024-10-24 15:02         ` Angelo Dureghello
2024-10-24 15:13           ` David Lechner
2024-10-26 17:35             ` Jonathan Cameron [this message]
2024-10-25  6:13           ` Nuno Sá
2024-10-21 12:40 ` [PATCH v7 8/8] iio: dac: adi-axi-dac: add registering of child fdt node Angelo Dureghello
2024-10-22 12:02   ` Nuno Sá

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241026183502.40662850@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=adureghello@baylibre.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=noname.nuno@gmail.com \
    --cc=nuno.sa@analog.com \
    --cc=olivier.moysan@foss.st.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox