Re: [PATCH v2] iio: adc: ad7380: use if_not_cond_guard for claim direct

[kernel test robot <lkp@intel.com>]

Hi David,

kernel test robot noticed the following build errors:

[auto build test ERROR on 431c39f6d3edbab14f48dbf37a58ccdc0ac3be1e]

url:    https://github.com/intel-lab-lkp/linux/commits/David-Lechner/iio-adc-ad7380-use-if_not_cond_guard-for-claim-direct/20241025-001415
base:   431c39f6d3edbab14f48dbf37a58ccdc0ac3be1e
patch link:    https://lore.kernel.org/r/20241024-cleanup-if_not_cond_guard-v2-1-1bef98c9fd2e%40baylibre.com
patch subject: [PATCH v2] iio: adc: ad7380: use if_not_cond_guard for claim direct
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20241027/202410271218.9sti93hi-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241027/202410271218.9sti93hi-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410271218.9sti93hi-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/iio/adc/ad7380.c: In function 'ad7380_debugfs_reg_access':
>> drivers/iio/adc/ad7380.c:574:9: error: implicit declaration of function 'if_not_cond_guard' [-Werror=implicit-function-declaration]
     574 |         if_not_cond_guard(iio_claim_direct_try, indio_dev)
         |         ^~~~~~~~~~~~~~~~~
>> drivers/iio/adc/ad7380.c:574:27: error: 'iio_claim_direct_try' undeclared (first use in this function); did you mean 'class_iio_claim_direct_try_t'?
     574 |         if_not_cond_guard(iio_claim_direct_try, indio_dev)
         |                           ^~~~~~~~~~~~~~~~~~~~
         |                           class_iio_claim_direct_try_t
   drivers/iio/adc/ad7380.c:574:27: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/iio/adc/ad7380.c:574:59: error: expected ';' before 'return'
     574 |         if_not_cond_guard(iio_claim_direct_try, indio_dev)
         |                                                           ^
         |                                                           ;
     575 |                 return -EBUSY;
         |                 ~~~~~~                                     
   drivers/iio/adc/ad7380.c: In function 'ad7380_read_raw':
   drivers/iio/adc/ad7380.c:823:35: error: 'iio_claim_direct_try' undeclared (first use in this function); did you mean 'class_iio_claim_direct_try_t'?
     823 |                 if_not_cond_guard(iio_claim_direct_try, indio_dev)
         |                                   ^~~~~~~~~~~~~~~~~~~~
         |                                   class_iio_claim_direct_try_t
   drivers/iio/adc/ad7380.c:823:67: error: expected ';' before 'return'
     823 |                 if_not_cond_guard(iio_claim_direct_try, indio_dev)
         |                                                                   ^
         |                                                                   ;
     824 |                         return -EBUSY;
         |                         ~~~~~~                                     
   drivers/iio/adc/ad7380.c: In function 'ad7380_write_raw':
   drivers/iio/adc/ad7380.c:912:35: error: 'iio_claim_direct_try' undeclared (first use in this function); did you mean 'class_iio_claim_direct_try_t'?
     912 |                 if_not_cond_guard(iio_claim_direct_try, indio_dev)
         |                                   ^~~~~~~~~~~~~~~~~~~~
         |                                   class_iio_claim_direct_try_t
   drivers/iio/adc/ad7380.c:912:67: error: expected ';' before 'return'
     912 |                 if_not_cond_guard(iio_claim_direct_try, indio_dev)
         |                                                                   ^
         |                                                                   ;
     913 |                         return -EBUSY;
         |                         ~~~~~~                                     
   cc1: some warnings being treated as errors

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for MODVERSIONS
   Depends on [n]: MODULES [=y] && !COMPILE_TEST [=y]
   Selected by [y]:
   - RANDSTRUCT_FULL [=y] && (CC_HAS_RANDSTRUCT [=n] || GCC_PLUGINS [=y]) && MODULES [=y]
   WARNING: unmet direct dependencies detected for GET_FREE_REGION
   Depends on [n]: SPARSEMEM [=n]
   Selected by [m]:
   - RESOURCE_KUNIT_TEST [=m] && RUNTIME_TESTING_MENU [=y] && KUNIT [=m]


vim +/if_not_cond_guard +574 drivers/iio/adc/ad7380.c

   568	
   569	static int ad7380_debugfs_reg_access(struct iio_dev *indio_dev, u32 reg,
   570					     u32 writeval, u32 *readval)
   571	{
   572		struct ad7380_state *st = iio_priv(indio_dev);
   573	
 > 574		if_not_cond_guard(iio_claim_direct_try, indio_dev)
   575			return -EBUSY;
   576	
   577		if (readval)
   578			return regmap_read(st->regmap, reg, readval);
   579	
   580		return regmap_write(st->regmap, reg, writeval);
   581	}
   582	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki