From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH v2 0/4] iio: initialise ddata for iio_get_acpi_device_name_and_data()
Date: Fri, 1 Nov 2024 14:56:58 +0000 [thread overview]
Message-ID: <20241101145658.25c0bd11@jic23-huawei> (raw)
In-Reply-To: <20241101081203.3360421-1-andriy.shevchenko@linux.intel.com>
On Fri, 1 Nov 2024 10:08:25 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> Dan reported that ddata might be used uninitialised in some cases.
> Let's initialise it to NULL (patches 1 - 3). With that, update one driver
> to drop an unneeded anymore check (included in patch 3).
>
> While at it, one more cleanup to kxcjk-1013 (patch 4) is added.
>
> Jonathan, dunno if you want to rebase at this stage (probably not),
> but if you do, feel free to fold the patches 1-3 to the initial code.
I had to rebase anyway for another reason so given that squashed those 3 in.
4 is on top of the tree.
Thanks,
Jonathan
>
> In v2:
> - rewritten patches 1-3 to do the job on the caller side (Jonathan)
>
> Andy Shevchenko (4):
> iio: light: ltr501: Assing ddata to NULL
> iio: light: isl29018: Assing ddata to NULL
> iio: accel: kxcjk-1013: Assing ddata to NULL instead of NULL check
> iio: accel: kxcjk-1013: Deduplicate ODR startup time array
>
> drivers/iio/accel/kxcjk-1013.c | 30 ++++++------------------------
> drivers/iio/light/isl29018.c | 2 +-
> drivers/iio/light/ltr501.c | 2 +-
> 3 files changed, 8 insertions(+), 26 deletions(-)
>
prev parent reply other threads:[~2024-11-01 14:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 8:08 [PATCH v2 0/4] iio: initialise ddata for iio_get_acpi_device_name_and_data() Andy Shevchenko
2024-11-01 8:08 ` [PATCH v2 1/4] iio: light: ltr501: Assing ddata to NULL Andy Shevchenko
2024-11-01 10:56 ` Markus Elfring
2024-11-01 12:43 ` Markus Elfring
2024-11-01 8:08 ` [PATCH v2 2/4] iio: light: isl29018: " Andy Shevchenko
2024-11-01 14:27 ` Markus Elfring
2024-11-01 8:08 ` [PATCH v2 3/4] iio: accel: kxcjk-1013: Assing ddata to NULL instead of NULL check Andy Shevchenko
2024-11-01 14:45 ` Markus Elfring
2024-11-01 8:08 ` [PATCH v2 4/4] iio: accel: kxcjk-1013: Deduplicate ODR startup time array Andy Shevchenko
2024-11-01 14:56 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241101145658.25c0bd11@jic23-huawei \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox