Re: [PATCH v2 10/15] iio: imu: bmi323: use bool for event state

Jonathan Cameron
2024-11-01T16:35:46Z

On Thu, 31 Oct 2024 16:27:05 +0100
Julien Stephan <jstephan@baylibre.com> wrote:

> Since the write_event_config callback now uses a bool for the state
> parameter, update the signatures of the functions it calls accordingly.
>
> Signed-off-by: Julien Stephan <jstephan@baylibre.com>
Applied.
> ---
> drivers/iio/imu/bmi323/bmi323_core.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iio/imu/bmi323/bmi323_core.c b/drivers/iio/imu/bmi323/bmi323_core.c
> index 76a88e1ccc1d89988eb52d6b1be8da0f5005f0e6..161bb1d2e761688dd740635f8a2830e9562d1b59 100644
> --- a/drivers/iio/imu/bmi323/bmi323_core.c
> +++ b/drivers/iio/imu/bmi323/bmi323_core.c
> @@ -467,7 +467,7 @@ static int bmi323_feature_engine_events(struct bmi323_data *data,
> BMI323_FEAT_IO_STATUS_MSK);
> }
>
> -static int bmi323_step_wtrmrk_en(struct bmi323_data *data, int state)
> +static int bmi323_step_wtrmrk_en(struct bmi323_data *data, bool state)
> {
> enum bmi323_irq_pin step_irq;
> int ret;
> @@ -484,7 +484,7 @@ static int bmi323_step_wtrmrk_en(struct bmi323_data *data, int state)
> ret = bmi323_update_ext_reg(data, BMI323_STEP_SC1_REG,
> BMI323_STEP_SC1_WTRMRK_MSK,
> FIELD_PREP(BMI323_STEP_SC1_WTRMRK_MSK,
> - state ? 1 : 0));
> + state));
> if (ret)
> return ret;
>
> @@ -506,7 +506,7 @@ static int bmi323_motion_config_reg(enum iio_event_direction dir)
> }
>
> static int bmi323_motion_event_en(struct bmi323_data *data,
> - enum iio_event_direction dir, int state)
> + enum iio_event_direction dir, bool state)
> {
> unsigned int state_value = state ? BMI323_FEAT_XYZ_MSK : 0;
> int config, ret, msk, raw, field_value;
> @@ -570,7 +570,7 @@ static int bmi323_motion_event_en(struct bmi323_data *data,
> }
>
> static int bmi323_tap_event_en(struct bmi323_data *data,
> - enum iio_event_direction dir, int state)
> + enum iio_event_direction dir, bool state)
> {
> enum bmi323_irq_pin tap_irq;
> int ret, tap_enabled;
>