Re: [PATCH v2 05/15] iio: proximity: sx9500: simplify code in write_event_config callback

Jonathan Cameron
2024-11-01T15:37:09Z

On Thu, 31 Oct 2024 16:27:00 +0100
Julien Stephan <jstephan@baylibre.com> wrote:

> iio_ev_state_store is actually using kstrtobool to check user
> input, then gives the converted boolean value to the write_event_config
> callback.
>
> Remove useless code in write_event_config callback.
>
> Signed-off-by: Julien Stephan <jstephan@baylibre.com>
Applied and pushed out as testing. Still time for other reviews if anyone
cares to take a look.

Thanks,

Jonathan

> ---
> drivers/iio/proximity/sx9500.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/proximity/sx9500.c b/drivers/iio/proximity/sx9500.c
> index 3f4eace05cfc6a4679fe82854dc059aa4a710d6d..e3da709424d5b2bd4e746df7adc4a4969e62f2a6 100644
> --- a/drivers/iio/proximity/sx9500.c
> +++ b/drivers/iio/proximity/sx9500.c
> @@ -551,7 +551,7 @@ static int sx9500_write_event_config(struct iio_dev *indio_dev,
>
> mutex_lock(&data->mutex);
>
> - if (state == 1) {
> + if (state) {
> ret = sx9500_inc_chan_users(data, chan->channel);
> if (ret < 0)
> goto out_unlock;
> @@ -571,7 +571,7 @@ static int sx9500_write_event_config(struct iio_dev *indio_dev,
> goto out_unlock;
>
> out_undo_chan:
> - if (state == 1)
> + if (state)
> sx9500_dec_chan_users(data, chan->channel);
> else
> sx9500_inc_chan_users(data, chan->channel);
>