Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: victor.duicu@microchip.com, matteomartelli3@gmail.com,
	lars@metafoo.de, marius.cristea@microchip.com,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7] iio: adc: pac1921: Add ACPI support to Microchip pac1921
Date: Sun, 3 Nov 2024 11:10:23 +0000	[thread overview]
Message-ID: <20241103111023.691164a2@jic23-huawei> (raw)
In-Reply-To: <ZyaB9G1baF10FzZD@surfacebook.localdomain>

On Sat, 2 Nov 2024 21:48:04 +0200
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:

> Thu, Oct 31, 2024 at 08:52:05AM +0200, victor.duicu@microchip.com kirjoitti:
> > From: Victor Duicu <victor.duicu@microchip.com>
> > 
> > This patch implements ACPI support to Microchip pac1921.
> > The driver can read shunt resistor value and label from ACPI table.  
> 
> This ID might be okay, but can we please have:
> 1) the list of the models (or a model) of the device on the market that has this;
> 2) ACPI DSDT excerpt of the respective Device object?
> 
> (I mean a laptop, tablet, phone or other device that has this sensor described
> in the ACPI)

For a valid ID used in a patch submitted by an employee of the relevant
company this is a steep ask.  As far as I'm concerned it is definitely not
a requirement (unlike for non compliant IDs!) There is no reason why a
device might be public at this time. 

For a good upstream first company almost all IDs go into the kernel
'before' device announcement or sales.  I very much want to encourage
that not put potential barriers in the way.

So Victor, if you can provide the info Andy requested, then great but if not
feel free to say so. (+ the snippet is useful anyway and is unlikely
to contain anything confidential.) 

Jonathan



  reply	other threads:[~2024-11-03 11:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-31  6:52 [PATCH v7] iio: adc: pac1921: Add ACPI support to Microchip pac1921 victor.duicu
2024-11-02 15:45 ` Jonathan Cameron
2024-11-03 11:01   ` Jonathan Cameron
2024-11-02 19:48 ` Andy Shevchenko
2024-11-03 11:10   ` Jonathan Cameron [this message]
2024-11-05  8:31   ` Victor.Duicu
2024-11-02 20:01 ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241103111023.691164a2@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marius.cristea@microchip.com \
    --cc=matteomartelli3@gmail.com \
    --cc=victor.duicu@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox