From: Jonathan Cameron <jic23@kernel.org>
To: "Nuno Sá" <noname.nuno@gmail.com>
Cc: David Lechner <dlechner@baylibre.com>,
Michael Hennerich <Michael.Hennerich@analog.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: ad7173: remove unused field
Date: Sat, 9 Nov 2024 15:18:56 +0000 [thread overview]
Message-ID: <20241109151856.049c18b2@jic23-huawei> (raw)
In-Reply-To: <f1aff5adfb369c3926e43b7ecaa95d23e0126343.camel@gmail.com>
On Tue, 05 Nov 2024 08:44:40 +0100
Nuno Sá <noname.nuno@gmail.com> wrote:
> On Mon, 2024-11-04 at 13:42 -0600, David Lechner wrote:
> > Remove the unused chan_reg field from struct ad7173_channel. This was
> > set but never read.
> >
> > Signed-off-by: David Lechner <dlechner@baylibre.com>
> > ---
>
> Reviewed-by: Nuno Sa <nuno.sa@analog.com>
>
> > Noticed this while looking over the code.
Applied.
> > ---
> > drivers/iio/adc/ad7173.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/iio/adc/ad7173.c b/drivers/iio/adc/ad7173.c
> > index a0fca16c3be0..29ff9c7036c0 100644
> > --- a/drivers/iio/adc/ad7173.c
> > +++ b/drivers/iio/adc/ad7173.c
> > @@ -193,7 +193,6 @@ struct ad7173_channel_config {
> > };
> >
> > struct ad7173_channel {
> > - unsigned int chan_reg;
> > unsigned int ain;
> > struct ad7173_channel_config cfg;
> > };
> > @@ -1316,7 +1315,6 @@ static int ad7173_fw_parse_channel_config(struct iio_dev
> > *indio_dev)
> > chan->address = chan_index;
> > chan->scan_index = chan_index;
> > chan->channel = ain[0];
> > - chan_st_priv->chan_reg = chan_index;
> > chan_st_priv->cfg.input_buf = st->info->has_input_buf;
> > chan_st_priv->cfg.odr = 0;
> >
> >
> > ---
> > base-commit: 56686ac80b859c2049cc372f7837470aa71c98cf
> > change-id: 20241104-iio-adc-ad7173-remove-unused-field-e3d2ca362501
> >
> > Best regards,
>
prev parent reply other threads:[~2024-11-09 15:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-04 19:42 [PATCH] iio: adc: ad7173: remove unused field David Lechner
2024-11-05 7:44 ` Nuno Sá
2024-11-09 15:18 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241109151856.049c18b2@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=dlechner@baylibre.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noname.nuno@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox