From: Jonathan Cameron <jic23@kernel.org>
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: dac: mcp4725: Use of_property_present() for non-boolean properties
Date: Sat, 9 Nov 2024 15:20:19 +0000 [thread overview]
Message-ID: <20241109152019.7eb9051e@jic23-huawei> (raw)
In-Reply-To: <20241104190846.278417-1-robh@kernel.org>
On Mon, 4 Nov 2024 13:08:46 -0600
"Rob Herring (Arm)" <robh@kernel.org> wrote:
> The use of of_property_read_bool() for non-boolean properties is
> deprecated in favor of of_property_present() when testing for property
> presence.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Applied to the testing branch of iio.git. I'll rebase that on 6.13-rc1
once available and push out for linux-next to pick up.
thanks,
Jonathan
> ---
> drivers/iio/dac/mcp4725.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/dac/mcp4725.c b/drivers/iio/dac/mcp4725.c
> index 25bb1c0490af..1337fb02ccf5 100644
> --- a/drivers/iio/dac/mcp4725.c
> +++ b/drivers/iio/dac/mcp4725.c
> @@ -379,7 +379,7 @@ static int mcp4725_probe_dt(struct device *dev,
> struct mcp4725_platform_data *pdata)
> {
> /* check if is the vref-supply defined */
> - pdata->use_vref = device_property_read_bool(dev, "vref-supply");
> + pdata->use_vref = device_property_present(dev, "vref-supply");
> pdata->vref_buffered =
> device_property_read_bool(dev, "microchip,vref-buffered");
>
prev parent reply other threads:[~2024-11-09 15:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-04 19:08 [PATCH] iio: dac: mcp4725: Use of_property_present() for non-boolean properties Rob Herring (Arm)
2024-11-09 15:20 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241109152019.7eb9051e@jic23-huawei \
--to=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox