From: Jonathan Cameron <jic23@kernel.org>
To: Guillaume Ranquet <granquet@baylibre.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: ad7173: add calibration support
Date: Sun, 24 Nov 2024 19:20:15 +0000 [thread overview]
Message-ID: <20241124192015.0f1b069e@jic23-huawei> (raw)
In-Reply-To: <20241115-ad411x_calibration-v1-1-5f820dfb5c80@baylibre.com>
On Fri, 15 Nov 2024 11:12:00 +0100
Guillaume Ranquet <granquet@baylibre.com> wrote:
> The ad7173 family of chips has up to four calibration modes.
>
> Internal zero scale: removes ADC core offset errors.
> Internal full scale: removes ADC core gain errors.
> System zero scale: reduces offset error to the order of channel noise.
> System full scale: reduces gain error to the order of channel noise.
>
> All voltage channels will undergo an internal zero/full scale
> calibration at bootup.
>
> System zero/full scale can be done after bootup using the newly created
> iio interface 'sys_calibration' and 'sys_calibration_mode'
>
> Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
> ---
> Calibration on the ad7173 family is the same as on the ad7192 family of
> chips and mostly uses the ad_sigma_delta common code.
The documentation in sysfs-bus-iio-adc-ad7192 needs promoting.
It is still fairly devices specific though.
Maybe we need a
sysfs-bus-iio-adc-ad ?
Note that documentation can only be in one file for a given attribute
or the docs build system complains.
Other than that, looks good to me.
Jonathan
prev parent reply other threads:[~2024-11-24 19:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-15 10:12 [PATCH] iio: adc: ad7173: add calibration support Guillaume Ranquet
2024-11-24 19:20 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241124192015.0f1b069e@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=granquet@baylibre.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox