From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Peter Rosin <peda@axentia.se>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>
Subject: [PATCH v1 1/4] iio: afe: rescale: Don't use ^ for booleans
Date: Wed, 4 Dec 2024 03:33:16 +0200 [thread overview]
Message-ID: <20241204013620.862943-2-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20241204013620.862943-1-andriy.shevchenko@linux.intel.com>
There are two (non-critical) issues with the code. First of all,
the eXclusive OR is not defined for booleans, so boolean to integer
promotion is required, Second, the u32 variable is used to keep
boolean value, so boolean is converted implicitly to the integer.
All these are not needed when variable is defined as boolean to begin
with and operations are replaced by simple != and ||.
Fixes: 701ee14da95d ("iio: afe: rescale: add INT_PLUS_{MICRO,NANO} support")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/iio/afe/iio-rescale.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/afe/iio-rescale.c b/drivers/iio/afe/iio-rescale.c
index b6a46036d5ea..470dd7d41b2a 100644
--- a/drivers/iio/afe/iio-rescale.c
+++ b/drivers/iio/afe/iio-rescale.c
@@ -26,7 +26,7 @@ int rescale_process_scale(struct rescale *rescale, int scale_type,
int _val, _val2;
s32 rem, rem2;
u32 mult;
- u32 neg;
+ bool neg;
switch (scale_type) {
case IIO_VAL_INT:
@@ -95,7 +95,7 @@ int rescale_process_scale(struct rescale *rescale, int scale_type,
* If only one of the rescaler elements or the schan scale is
* negative, the combined scale is negative.
*/
- if (neg ^ ((rescale->numerator < 0) ^ (rescale->denominator < 0))) {
+ if (neg != (rescale->numerator < 0 || rescale->denominator < 0)) {
if (*val)
*val = -*val;
else
--
2.43.0.rc1.1336.g36b5255a03ac
next prev parent reply other threads:[~2024-12-04 1:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 1:33 [PATCH v1 0/4] iio: afe: rescale: A few cleanups Andy Shevchenko
2024-12-04 1:33 ` Andy Shevchenko [this message]
2024-12-06 13:24 ` [PATCH v1 1/4] iio: afe: rescale: Don't use ^ for booleans David Laight
2024-12-06 15:19 ` 'Andy Shevchenko'
2024-12-06 20:13 ` David Laight
2024-12-06 22:27 ` Peter Rosin
2024-12-04 1:33 ` [PATCH v1 2/4] iio: afe: rescale: Don't use ULL(1) << x instead of BIT(x) Andy Shevchenko
2024-12-04 1:33 ` [PATCH v1 3/4] iio: afe: rescale: Re-use generic struct s32_fract Andy Shevchenko
2024-12-04 11:11 ` kernel test robot
2024-12-04 11:32 ` kernel test robot
2024-12-04 1:33 ` [PATCH v1 4/4] iio: afe: rescale: Don't use "proxy" headers Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241204013620.862943-2-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox