Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Francesco Dolcini <francesco@dolcini.it>
Cc: "Javier Carrasco" <javier.carrasco.cruz@gmail.com>,
	"João Paulo Gonçalves" <jpaulo.silvagoncalves@gmail.com>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"João Paulo Gonçalves" <joao.goncalves@toradex.com>,
	"Francesco Dolcini" <francesco.dolcini@toradex.com>,
	"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: ti-ads1119: fix sample size in scan struct for triggered buffer
Date: Sun, 8 Dec 2024 16:59:44 +0000	[thread overview]
Message-ID: <20241208165944.1ca1d08b@jic23-huawei> (raw)
In-Reply-To: <20241202194622.GA70146@francesco-nb>

On Mon, 2 Dec 2024 20:46:22 +0100
Francesco Dolcini <francesco@dolcini.it> wrote:

> On Mon, Dec 02, 2024 at 08:18:44PM +0100, Javier Carrasco wrote:
> > This device returns signed, 16-bit samples as stated in its datasheet
> > (see 8.5.2 Data Format). That is in line with the scan_type definition
> > for the IIO_VOLTAGE channel, but 'unsigned int' is being used to read
> > and push the data to userspace.
> > 
> > Given that the size of that type depends on the architecture (at least
> > 2 bytes to store values up to 65535, but its actual size is often 4
> > bytes), use the 's16' type to provide the same structure in all cases.
> > 
> > Fixes: a9306887eba4 ("iio: adc: ti-ads1119: Add driver")
> > Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>  
> 
> Reviewed-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> Cc: stable@vger.kernel.org
> 
> Thanks,
> Francesco
> 

Applied to the fixes-togreg branch of iio.git and marked for stable.

Thanks,

Jonathan

      reply	other threads:[~2024-12-08 16:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-02 19:18 [PATCH] iio: adc: ti-ads1119: fix sample size in scan struct for triggered buffer Javier Carrasco
2024-12-02 19:46 ` Francesco Dolcini
2024-12-08 16:59   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241208165944.1ca1d08b@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=francesco.dolcini@toradex.com \
    --cc=francesco@dolcini.it \
    --cc=javier.carrasco.cruz@gmail.com \
    --cc=joao.goncalves@toradex.com \
    --cc=jpaulo.silvagoncalves@gmail.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox