From: Chris Morgan <macroalpha82@gmail.com>
To: linux-pm@vger.kernel.org
Cc: linux-iio@vger.kernel.org, andre.przywara@arm.com,
lee@kernel.org, wens@csie.org, sre@kernel.org, lars@metafoo.de,
jic23@kernel.org, Chris Morgan <macromorgan@hotmail.com>
Subject: [PATCH 0/2] Fix Regression with AXP20X for 6.13-rc1
Date: Tue, 10 Dec 2024 16:48:57 -0600 [thread overview]
Message-ID: <20241210224859.58917-1-macroalpha82@gmail.com> (raw)
From: Chris Morgan <macromorgan@hotmail.com>
After performing a git bisect, I identified a commit that broke the
battery and charger driver for my AXP717 PMIC. This was caused by
commit e37ec3218870 ("mfd: axp20x: Allow multiple regulators").
After digging into it, it appears when mfd_add_devices was called with
a platform ID of PLATFORM_DEVID_NONE, the devm_iio_channel_get() call
made by the various AXP20X power drivers would not be able to generate
a dev_name(dev) for some reason, and the iio_channel_get() call used in
the devm_ helper would fall back to making a iio_channel_get_sys()
call. After the platform ID was updated, now iio_channel_get() is no
longer falling back to iio_channel_get_sys(). At least this is my
limited understanding of what happened.
To fix this, I added a new devm_ helper of devm_iio_channel_get_sys()
that directly calls iio_channel_get_sys(), and I updated all the
affected drivers with the new routine. I then no longer experienced
any issues with the drivers on my devices.
Chris Morgan (2):
iio: core: Add devm_ API for iio_channel_get_sys
power: supply: axp20x: Use devm_iio_channel_get_sys() for iio chans
drivers/iio/inkern.c | 18 ++++++++++++++++++
drivers/power/supply/axp20x_ac_power.c | 4 ++--
drivers/power/supply/axp20x_battery.c | 16 ++++++++--------
drivers/power/supply/axp20x_usb_power.c | 6 +++---
include/linux/iio/consumer.h | 20 ++++++++++++++++++++
5 files changed, 51 insertions(+), 13 deletions(-)
--
2.43.0
next reply other threads:[~2024-12-10 22:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-10 22:48 Chris Morgan [this message]
2024-12-10 22:48 ` [PATCH 1/2] iio: core: Add devm_ API for iio_channel_get_sys Chris Morgan
2024-12-10 22:48 ` [PATCH 2/2] power: supply: axp20x: Use devm_iio_channel_get_sys() for iio chans Chris Morgan
2024-12-11 21:58 ` [PATCH 0/2] Fix Regression with AXP20X for 6.13-rc1 Jonathan Cameron
2024-12-11 22:06 ` Jonathan Cameron
2024-12-16 18:01 ` Chris Morgan
2024-12-16 18:04 ` Chen-Yu Tsai
2025-03-04 18:18 ` Chris Morgan
2025-03-04 23:29 ` Jonathan Cameron
2025-03-06 2:19 ` Chris Morgan
2025-03-08 17:11 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241210224859.58917-1-macroalpha82@gmail.com \
--to=macroalpha82@gmail.com \
--cc=andre.przywara@arm.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=lee@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=macromorgan@hotmail.com \
--cc=sre@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox