From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A2C1204088; Wed, 11 Dec 2024 18:30:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733941806; cv=none; b=cGfJJqeesVFhybged3HYUcIN1d7/f+jiTnv09aCjlPO/cxTyP3hmIf2GmDE33e+ZEnknYEAsCBBO35tXkLtj1+sFNGJTO+T0LJvkmfR7ANu9eh797ulYYKKL/gX1if4sDYC8NGPut81uX/ArySOpYk8sLmOUKsxZz49k+b6nyQQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733941806; c=relaxed/simple; bh=3EOPBqTl7kOiXAdzXvznRh9sU5nZldiuzqryJ/CeS/0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=HHiM8l7gi8FMKC1S9PudNkoK7Q6HmeCbrmpmmd/OgFhQ3EzYiWpUpvetUPRBUCHTbmM92Y4PzxKYt/3Ne5J3xrId1RudHDv2sZ73+2gxbx3Gpatr4mWMcyCK1yRvmP6i52OuTNLl2lfKNXJzdZnFQ2vDfaA9zI0rrlfSG1fjJB4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MRs+ikbT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MRs+ikbT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91894C4CED2; Wed, 11 Dec 2024 18:30:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1733941806; bh=3EOPBqTl7kOiXAdzXvznRh9sU5nZldiuzqryJ/CeS/0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=MRs+ikbTgJ//ePzjAixtOtsqlN7s6XebBPOU0MOXmAkGHvUVuHwuIAkf8if5GcT3y ueVaq3p+vQ3rFKDYu1gL7eFJ1qgUSPem4YIhJwSWVlBcZLrXSw0KntB7g0UykX592G 1ga5Tdt+HcMK5WxugypcBTQboSfroam2kuap+5jx8d/H6oK6uz7BhiMoum9xUbSged J/j0tkSM4fI2O3zLMFHggpozZcGy/GxT4QvqlIY60cWJa73nU2G651JI/VRgo/fl+f /sdQTyHaqRbErQQDB13C4oF2PrXmEn/I/L40N/hAAWZDDNLAaikArqF8AJqTAZ7sja z0sMOeRUALfuw== Date: Wed, 11 Dec 2024 18:29:58 +0000 From: Jonathan Cameron To: Andy Shevchenko Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Lars-Peter Clausen , gregkh@linuxfoundation.org, "Rafael J. Wysocki" Subject: Re: [PATCH v1 1/2] driver core: Split devres APIs to device/devres.h Message-ID: <20241211182958.5afc82c4@jic23-huawei> In-Reply-To: References: <20241203195340.855879-1-andriy.shevchenko@linux.intel.com> <20241203195340.855879-2-andriy.shevchenko@linux.intel.com> <20241208171001.4994e749@jic23-huawei> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 9 Dec 2024 02:45:46 +0200 Andy Shevchenko wrote: > On Sun, Dec 08, 2024 at 05:10:01PM +0000, Jonathan Cameron wrote: > > On Tue, 3 Dec 2024 21:48:51 +0200 > > Andy Shevchenko wrote: > > > > > device.h is a huge header which is hard to follow and easy to miss > > > something. Improve that by splitting devres APIs to device/devres.h. > > > > > > In particular this helps to speedup the build of the code that includes > > > device.h solely for a devres APIs. > > ... > > > > -#include > > > + > > Unrelated change. > > Which one? Blank line? I think that's what I meant :) Was a trivial comment though. > > ... > > > > -#include > > This header movement is unrelated. > > No problem to let it stay at the same place. > > > I agree both are good but probably want to be a separate patch. > > > > Otherwise this seems sensible to me, but your cc list seems a little short! > > > > Greg and Rafael seems a good starting point so I've added them. > > Thanks! I need to check why they were not included into the original > submission. Perhpas I need to amend MAINTAINERS, >