Re: [PATCH v8 3/8] iio: backend: add API for oversampling

[Jonathan Cameron <jic23@kernel.org>]

On Fri, 13 Dec 2024 17:10:58 -0600
David Lechner <dlechner@baylibre.com> wrote:

> On 12/13/24 10:44 AM, Antoniu Miclaus wrote:
> > Add backend support for setting oversampling ratio.
> > 
> > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> > ---
> > changes in v8:
> >  - pass oversampling ratio
> >  drivers/iio/industrialio-backend.c | 15 +++++++++++++++
> >  include/linux/iio/backend.h        |  5 +++++
> >  2 files changed, 20 insertions(+)
> > 
> > diff --git a/drivers/iio/industrialio-backend.c b/drivers/iio/industrialio-backend.c
> > index ea184fc2c838..e56b1e96652d 100644
> > --- a/drivers/iio/industrialio-backend.c
> > +++ b/drivers/iio/industrialio-backend.c
> > @@ -681,6 +681,21 @@ int iio_backend_data_size_set(struct iio_backend *back, unsigned int size)
> >  }
> >  EXPORT_SYMBOL_NS_GPL(iio_backend_data_size_set, IIO_BACKEND);
> >  
> > +/**
> > + * iio_backend_oversampling_ratio_set - set the oversampling ratio
> > + * @back: Backend device
> > + * @ratio: The oversampling ratio

The 0 vs 1 as no oversampling debate has happened a few times.  Perhaps just
add to documentation here to say 1 is used to mean no oversampling.

Thanks,

Jonathan

> > + *
> > + * Return:
> > + * 0 on success, negative error number on failure.
> > + */
> > +int iio_backend_oversampling_ratio_set(struct iio_backend *back,
> > +				       unsigned int ratio)
> > +{
> > +	return iio_backend_op_call(back, oversampling_ratio_set, ratio);
> > +}
> > +EXPORT_SYMBOL_NS_GPL(iio_backend_oversampling_ratio_set, IIO_BACKEND);
> > +  
> Needs quotes on "IIO_BACKEND" here.
> 
> With that...
> 
> Reviewed-by: David Lechner <dlechner@baylibre.com>
>