From: Jonathan Cameron <jic23@kernel.org>
To: "Nuno Sá" <noname.nuno@gmail.com>
Cc: "David Lechner" <dlechner@baylibre.com>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Antoniu Miclaus" <antoniu.miclaus@analog.com>,
"Nuno Sá" <nuno.sa@analog.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: dac: ad7293: enable power before reset
Date: Thu, 19 Dec 2024 16:37:58 +0000 [thread overview]
Message-ID: <20241219163758.6507221a@jic23-huawei> (raw)
In-Reply-To: <f24abf927dcd21866bdb335d5ed27f3be4d94705.camel@gmail.com>
On Tue, 17 Dec 2024 11:05:38 +0100
Nuno Sá <noname.nuno@gmail.com> wrote:
> On Mon, 2024-12-16 at 15:44 -0600, David Lechner wrote:
> > Change the order of regulator enable and reset so that power supplies
> > are turned on before touching the reset line. Generally, chips should
> > have the VDRIVE supply enabled before applying voltage on any pins.
> >
> > While we are at it, remove the voltage level checks. If the power
> > supplies are not supplying the correct voltage, this is a hardware
> > design problem, not a software problem.
> >
> > Signed-off-by: David Lechner <dlechner@baylibre.com>
> > ---
>
> Reviewed-by: Nuno Sa <nuno.sa@analog.com>
Applied. Thanks
prev parent reply other threads:[~2024-12-19 16:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-16 21:44 [PATCH v2] iio: dac: ad7293: enable power before reset David Lechner
2024-12-17 10:05 ` Nuno Sá
2024-12-19 16:37 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241219163758.6507221a@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=antoniu.miclaus@analog.com \
--cc=broonie@kernel.org \
--cc=dlechner@baylibre.com \
--cc=lgirdwood@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noname.nuno@gmail.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox