Re: [PATCH v2] iio: adc: ad7124: Micro-optimize channel disabling

[Jonathan Cameron <jic23@kernel.org>]

On Mon, 20 Jan 2025 15:52:20 +0000
Nuno Sá <noname.nuno@gmail.com> wrote:

> On Mon, 2025-01-20 at 15:07 +0100, Uwe Kleine-König wrote:
> > The key objective in ad7124_disable_one() is clearing the
> > AD7124_CHANNEL_EN_MSK bit in the channel register. However there is no
> > advantage to keep the other bits in that register because when the
> > channel is used next time, all fields are rewritten anyhow. So instead
> > of using ad7124_spi_write_mask() (which is a register read plus a
> > register write) use a simple register write clearing the complete
> > register.
> > 
> > Also do the same in the .disable_all() callback by using the
> > .disable_one() callback there.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> > ---  
> 
> Reviewed-by: Nuno Sa <nuno.sa@analog.com>
Applied.  Thanks,