Re: [PATCH 11/27] iio: adc: ad4695: Stop using iio_device_claim_direct_scoped()

[Jonathan Cameron <jic23@kernel.org>]

On Wed, 5 Feb 2025 17:28:42 -0600
David Lechner <dlechner@baylibre.com> wrote:

> On 2/4/25 2:02 PM, Jonathan Cameron wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > 
> > This complex cleanup.h use case of conditional guards has proved
> > to be more trouble that it is worth in terms of false positive compiler
> > warnings and hard to read code.
> > 
> > Move directly to the new claim/release_direct() that allow sparse
> > to check for unbalanced context.  In some cases code is factored
> > out to utility functions that can do a direect return with the  
> 
> s/direect/direct/
> 
> > claim and release around the call.
> > 
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Cc: David Lechner <dlechner@baylibre.com>
> > ---
> >  drivers/iio/adc/ad4695.c | 240 ++++++++++++++++++++++-----------------  
> 
> FYI, we still have a patch [1] hanging out in patchwork waiting for dependencies
> that will have a merge conflict with this. Should be able to pick up that patch
> since -rc1 and then rebase this one on it. Or we can do it the other way around.
> 
> [1]: https://patchwork.kernel.org/project/linux-iio/patch/20250109-ad4695-oversampling-v2-1-a46ac487082c@baylibre.com/

I tried that yesterday. Depends on your SPI offload series I think, so
no way to move that forwards yet.

I'm sending a v2 anyway for this series as enough small tweaks +
I'd like it to sit on list a little longer.

Jonathan

>