Re: [PATCH v2 0/6] iio: adc: ad{4130,7124,7173}: A few fixes and ad7124 calibration

[Jonathan Cameron <jic23@kernel.org>]

On Tue, 18 Feb 2025 19:31:07 +0100
Uwe Kleine-König <u.kleine-koenig@baylibre.com> wrote:

> Hello,
> 
> this v2 series is a rework of two series:
> 
> 	https://lore.kernel.org/iio/20250212105322.10243-5-u.kleine-koenig@baylibre.com
> 	https://lore.kernel.org/iio/cover.1738258777.git.u.kleine-koenig@baylibre.com
> 
> ; they overlap thematically and so I put them together in a single
> series.

I considered tidying up the things David raised in patch 2 and picking
the first 4 patches up now, but that doesn't give room for others to apply tags
if they want to, so I'll wait for v3.


> 
> Changes since their (implicit) v1:
> 
>  - Use static_assert instead of BUILD_BUG, add more comments to the "Fix
>    comparison" patches
>  - Make ad7124 internal calibration actually compile
>  - Sort the fix to the front of the series and add a Fixes: tag
>  - Implement system calibration
>  - More comments and commit log improvements
> 
> The "Fix comparison" patches trigger a checkpatch warning because the
> struct members are considered wrongly indented. For me the indention
> looks right, but I don't feel strong here and happily adapt if
> requested.
> 
> Best regards
> Uwe
> 
> Uwe Kleine-König (6):
>   iio: adc: ad_sigma_delta: Disable channel after calibration
>   iio: adc: ad4130: Fix comparison of channel setups
>   iio: adc: ad7124: Fix comparison of channel configs
>   iio: adc: ad7173: Fix comparison of channel configs
>   iio: adc: ad7124: Implement internal calibration at probe time
>   iio: adc: ad7124: Implement system calibration
> 
>  drivers/iio/adc/ad4130.c         |  41 ++++-
>  drivers/iio/adc/ad7124.c         | 293 ++++++++++++++++++++++++++++---
>  drivers/iio/adc/ad7173.c         |  25 ++-
>  drivers/iio/adc/ad_sigma_delta.c |   1 +
>  4 files changed, 331 insertions(+), 29 deletions(-)
> 
> base-commit: ac856912f210bcff6a1cf8cf9cb2f6a1dfe85798