From: Jonathan Cameron <jic23@kernel.org>
To: Matti Vaittinen <mazziesaccount@gmail.com>
Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Cosmin Tanislav <cosmin.tanislav@analog.com>,
Marcelo Schmitt <marcelo.schmitt@analog.com>,
Matteo Martelli <matteomartelli3@gmail.com>,
Yu Jiaoliang <yujiaoliang@vivo.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: Include cleanup.h when using guard()
Date: Sun, 2 Mar 2025 02:46:18 +0000 [thread overview]
Message-ID: <20250302024618.3d01c339@jic23-huawei> (raw)
In-Reply-To: <5b352ce7241e5904a317dd26950c7cd4daa59fc0.1740748394.git.mazziesaccount@gmail.com>
On Fri, 28 Feb 2025 15:14:03 +0200
Matti Vaittinen <mazziesaccount@gmail.com> wrote:
> Directly include the cleanup.h for the guard() instead of relying it to
> be included via other files.
>
> Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
Applied. Thanks,
J
> ---
> drivers/iio/adc/ad4130.c | 1 +
> drivers/iio/adc/ad7091r-base.c | 1 +
> drivers/iio/adc/ad7606.c | 1 +
> drivers/iio/adc/max34408.c | 1 +
> drivers/iio/adc/pac1921.c | 1 +
> 5 files changed, 5 insertions(+)
>
> diff --git a/drivers/iio/adc/ad4130.c b/drivers/iio/adc/ad4130.c
> index de32cc9d18c5..afcea2d6d494 100644
> --- a/drivers/iio/adc/ad4130.c
> +++ b/drivers/iio/adc/ad4130.c
> @@ -6,6 +6,7 @@
>
> #include <linux/bitfield.h>
> #include <linux/bitops.h>
> +#include <linux/cleanup.h>
> #include <linux/clk.h>
> #include <linux/clk-provider.h>
> #include <linux/delay.h>
> diff --git a/drivers/iio/adc/ad7091r-base.c b/drivers/iio/adc/ad7091r-base.c
> index 606486c4dfe8..931ff71b2888 100644
> --- a/drivers/iio/adc/ad7091r-base.c
> +++ b/drivers/iio/adc/ad7091r-base.c
> @@ -7,6 +7,7 @@
>
> #include <linux/bitops.h>
> #include <linux/bitfield.h>
> +#include <linux/cleanup.h>
> #include <linux/iio/events.h>
> #include <linux/iio/iio.h>
> #include <linux/interrupt.h>
> diff --git a/drivers/iio/adc/ad7606.c b/drivers/iio/adc/ad7606.c
> index d8e3c7a43678..11505846eb4f 100644
> --- a/drivers/iio/adc/ad7606.c
> +++ b/drivers/iio/adc/ad7606.c
> @@ -5,6 +5,7 @@
> * Copyright 2011 Analog Devices Inc.
> */
>
> +#include <linux/cleanup.h>
> #include <linux/delay.h>
> #include <linux/device.h>
> #include <linux/err.h>
> diff --git a/drivers/iio/adc/max34408.c b/drivers/iio/adc/max34408.c
> index 971e6e5dee9b..4f45fd22a90c 100644
> --- a/drivers/iio/adc/max34408.c
> +++ b/drivers/iio/adc/max34408.c
> @@ -8,6 +8,7 @@
> */
>
> #include <linux/bitfield.h>
> +#include <linux/cleanup.h>
> #include <linux/init.h>
> #include <linux/i2c.h>
> #include <linux/module.h>
> diff --git a/drivers/iio/adc/pac1921.c b/drivers/iio/adc/pac1921.c
> index 90f61c47b1c4..1c28df132e9f 100644
> --- a/drivers/iio/adc/pac1921.c
> +++ b/drivers/iio/adc/pac1921.c
> @@ -7,6 +7,7 @@
>
> #include <linux/unaligned.h>
> #include <linux/bitfield.h>
> +#include <linux/cleanup.h>
> #include <linux/i2c.h>
> #include <linux/iio/events.h>
> #include <linux/iio/iio.h>
>
> base-commit: d082ecbc71e9e0bf49883ee4afd435a77a5101b6
prev parent reply other threads:[~2025-03-02 2:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 13:14 [PATCH] iio: adc: Include cleanup.h when using guard() Matti Vaittinen
2025-03-02 2:46 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250302024618.3d01c339@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=cosmin.tanislav@analog.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt@analog.com \
--cc=matteomartelli3@gmail.com \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
--cc=yujiaoliang@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox