Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Jorge Marques <jorge.marques@analog.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>, <linux-iio@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio: Mark iio_dev as const in getter methods
Date: Wed, 5 Mar 2025 12:56:12 +0000	[thread overview]
Message-ID: <20250305125612.28ac7bc9@jic23-huawei> (raw)
In-Reply-To: <20250303-b4-iio-dev-const-v1-1-c2d9d5fe5ac1@analog.com>

On Mon, 3 Mar 2025 15:46:25 +0100
Jorge Marques <jorge.marques@analog.com> wrote:

> get_current_scan_type read-only method allows to support multiple
> scan types per channel, which may also depend on a buffer enabled state.
> Mark iio_dev as const in iio_device_id, iio_device_get_current_mode,
> iio_buffer_enabled read-only methods so they can be used from other
> read-only methods.
> 
> Signed-off-by: Jorge Marques <jorge.marques@analog.com>

Hi Jorge,

I'm not against this, but I would like to see this patch as part of
a series that uses it from a read-only method.

Until then this looks like noise unless there is other reasoning.

Thanks,

Jonathan


      reply	other threads:[~2025-03-05 12:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-03 14:46 [PATCH] iio: Mark iio_dev as const in getter methods Jorge Marques
2025-03-05 12:56 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250305125612.28ac7bc9@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=jorge.marques@analog.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox