From: Jonathan Cameron <jic23@kernel.org>
To: David Heidelberg via B4 Relay <devnull+david.ixit.cz@kernel.org>
Cc: david@ixit.cz, Lars-Peter Clausen <lars@metafoo.de>,
Svyatoslav Ryhel <clamor95@gmail.com>,
Robert Eckelmann <longnoserob@gmail.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] iio: light: al3320a: Implement regmap support
Date: Sun, 9 Mar 2025 16:47:53 +0000 [thread overview]
Message-ID: <20250309164753.2a14ceeb@jic23-huawei> (raw)
In-Reply-To: <20250308-al3010-iio-regmap-v1-4-b672535e8213@ixit.cz>
On Sat, 08 Mar 2025 21:01:01 +0100
David Heidelberg via B4 Relay <devnull+david.ixit.cz@kernel.org> wrote:
> From: David Heidelberg <david@ixit.cz>
>
> Modernize and make driver a bit cleaner.
>
> Incorporate most of the feedback given on new AL3000A.
>
> Signed-off-by: David Heidelberg <david@ixit.cz>
This one is more less just the regmap change, so main question is why does that
bring benefits? Code looks fine to me though one or two comments from review
of previous patch may apply here as well,
Thanks,
Jonathan
prev parent reply other threads:[~2025-03-09 16:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-08 20:00 [PATCH 0/4] iio: light: Modernize al3010 and al3320a codebase David Heidelberg via B4 Relay
2025-03-08 20:00 ` [PATCH 1/4] iio: light: al3320a: Drop deprecated email for Daniel David Heidelberg via B4 Relay
2025-03-09 16:30 ` Jonathan Cameron
2025-03-08 20:00 ` [PATCH 2/4] iio: light: al3000a: Use DRV_NAME David Heidelberg via B4 Relay
2025-03-09 16:33 ` Jonathan Cameron
2025-03-08 20:01 ` [PATCH 3/4] iio: light: al3010: Implement regmap support David Heidelberg via B4 Relay
2025-03-09 16:45 ` Jonathan Cameron
2025-03-09 21:11 ` David Heidelberg
2025-03-10 20:00 ` Jonathan Cameron
2025-03-08 20:01 ` [PATCH 4/4] iio: light: al3320a: " David Heidelberg via B4 Relay
2025-03-09 16:47 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250309164753.2a14ceeb@jic23-huawei \
--to=jic23@kernel.org \
--cc=clamor95@gmail.com \
--cc=david@ixit.cz \
--cc=devnull+david.ixit.cz@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longnoserob@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox