Re: [PATCH v7 1/6] dt-bindings: iio: filter: Add lpf/hpf freq margins

[Jonathan Cameron <jic23@kernel.org>]

On Tue, 18 Mar 2025 11:00:18 -0400
Sam Winchenbach <sam.winchenbach@framepointer.org> wrote:

> On Mon, Mar 17, 2025 at 06:55:35PM +0000, Jonathan Cameron wrote:
> > On Mon, 17 Mar 2025 11:07:32 -0400
> > Sam Winchenbach <sam.winchenbach@framepointer.org> wrote:
> >   
> > > On Sun, Mar 16, 2025 at 05:38:42PM +0100, Krzysztof Kozlowski wrote:  
> > > > On Sun, Mar 16, 2025 at 09:50:03AM -0400, Sam Winchenbach wrote:    
> > > > > From: Sam Winchenbach <swinchenbach@arka.org>
> > > > > 
> > > > > Adds two properties to add a margin when automatically finding the
> > > > > corner frequencies.
> > > > > 
> > > > > Signed-off-by: Sam Winchenbach <swinchenbach@arka.org>
> > > > > ---
> > > > >  .../bindings/iio/filter/adi,admv8818.yaml     | 20 +++++++++++++++++++
> > > > >  1 file changed, 20 insertions(+)    
> > > > 
> > > > I don't understand. You got my tag. No changelog here, no cover letter,
> > > > nothing explains what happened here and why the tag is being removed.
> > > >     
> > > 
> > > Apologies,
> > > 
> > > I am still quite new to this workflow, and it deviates significantly
> > > from my day-to-day work. I mentioned in the previous patch set that I
> > > would like to update my email address and change:
> > > "driver core: -> iio: core:"
> > > I wasn't aware more than that was needed. Sorry for any confusion
> > > this may have caused.
> > > 
> > > In the future what is the preferred way to handle a
> > > situation like this? I wasn't aware of the cover letter feature but
> > > that looks like a promising option.  
> > 
> > Either add stuff below the --- above as that doesn't end up in the
> > eventual git log, or --cover-letter on your git-format-patch and
> > put useful things like that in there.
> >   
> > > 
> > > It looks like another option is to add commentary to each patch.
> > > 
> > > I am less certain about your tag being removed - I don't fully
> > > understand that. Is there a way to preserve that if changes are made
> > > after you sign-off?  
> > 
> > Once a tag is given it is up to the patch author to add it to the
> > patches for future versions.  That should only be dropped if the
> > author thinks there are significant enough changes to warrant a fresh
> > review.  If you do drop a tag like that, then the change log
> > under --- on the particular patch should clearly state why.  
> > >   
> 
> Thanks for the guidance - I see the part I missed:
> 
> 
> "Both Tested-by and Reviewed-by tags, once received on mailing list
> from tester or reviewer, should be added by author to the applicable
> patches when sending next versions. However if the patch has changed
> substantially in following version, these tags might not be
> applicable anymore and thus should be removed. Usually removal of
> someone’s Tested-by or Reviewed-by tags should be mentioned in the
> patch changelog (after the ‘---’ separator)."
> 
> In my situation I made a mistake by not including his "Reviewed-by"
> in the changes I pushed up. How does this work if no further changes
> are required? Does it call onto the maintainer to apply the tag when
> merging in the change set?
> 
> Is there anything I should do at this point to correct my error?
It's a slightly messy case but I'd feel fine with a reply that said

oops I forgot to include
Reviewed-by: xxxx
as the scripts will pick that up.
> 
> Thanks,
> -Sam
> 
> > > Sorry again about the confusion this caused,  
> > No problem, takes a while for everyone to get used to a different
> > process. There are extensive docs, but it is still easy to miss
> > things!
> > 
> > Jonathan
> >   
> > > -Sam
> > >   
> > > > Best regards,
> > > > Krzysztof
> > > >     
> >