From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A67651AF0B4; Sun, 30 Mar 2025 17:45:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743356746; cv=none; b=QEHBbhhe+8bozUNN9/XajDN53fxa683Wuo/3QXF2hqGvodLp4hrRtLgTYVy35w9mpe6v4fraZlSSQbMTHx/1YW0DjUtgMGJLnsK7j1YRs2x4pfw2uAuUxeVBjAMpK2uL8WrTbSvri566dgahNXc67HnB0oREQxNj097o9nIn3rk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743356746; c=relaxed/simple; bh=KoXnUTs2TZp4zbjAe282b8MxrcLSis5hw2OlLkJTOyk=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=U7ZLIJpdQQafIA0g7ukAVcMHMc8msgL2iWK+IgjufHIWPrjetBfug+oURJmETIMFVO4zqH+ASNgszxa2gAby6eg1Kd2ID+D2xZTMghUOEmoy20+VviphrtSg0rOqKf23PGPF0BgZvgsyrr/eUWwpWl1KrzOTim5cYnMBix7ESYg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=opl99eRC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="opl99eRC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A952C4CEDD; Sun, 30 Mar 2025 17:45:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743356746; bh=KoXnUTs2TZp4zbjAe282b8MxrcLSis5hw2OlLkJTOyk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=opl99eRCyO/mDtBeJtRq7xRMOtTiFmAp70Of9L6Av9USBenM4JAb6YUBVoG9ludvj MIX23wT6C7Lj/NGp8BiwUKAzHnc/ES0WpCG8Zo9bVpk2xspcWdFJ9cIN2TstpIMwai K9RCNAD47q0q5ITXixtWmy2Z/XCZ3jyUbbRBykOtdCDoYVoG1HeNo+27PTsPDpjEOM kWcIkwoABqfDAnBOMSqIcjcyTdyxqqaA0oRaefMhUhqJ1dYiYjEpENo0u47SUI80fL W0CQkTw3wI0ckexvaj7jr0habpKFvLQR+f9spVMwADlu/mCYfusBWEo74tWZOkl1Hk YELJDyZcY1bAQ== Date: Sun, 30 Mar 2025 18:45:38 +0100 From: Jonathan Cameron To: David Heidelberg via B4 Relay Cc: david@ixit.cz, Lars-Peter Clausen , Svyatoslav Ryhel , Robert Eckelmann , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 12/13] iio: light: al3010: Implement regmap support Message-ID: <20250330184538.5b5e6f39@jic23-huawei> In-Reply-To: <20250319-al3010-iio-regmap-v2-12-1310729d0543@ixit.cz> References: <20250319-al3010-iio-regmap-v2-0-1310729d0543@ixit.cz> <20250319-al3010-iio-regmap-v2-12-1310729d0543@ixit.cz> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.48; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 19 Mar 2025 21:59:51 +0100 David Heidelberg via B4 Relay wrote: > From: David Heidelberg > > Modernize and make driver a bit cleaner. > > After the regmap implementation, the compiler is able to produce > much smaller module. > > Size before: 72 kB > Size after: 58 kB > > Signed-off-by: David Heidelberg Just one real comment on your code. Also a passing musing that you can feel free to ignore! Jonathan > static void al3010_set_pwr_off(void *_data) > { > struct al3010_data *data = _data; > + struct device *dev = regmap_get_device(data->regmap); > + int ret; > > - i2c_smbus_write_byte_data(data->client, AL3010_REG_SYSTEM, > - AL3010_CONFIG_DISABLE); > + ret = regmap_write(data->regmap, AL3010_REG_SYSTEM, AL3010_CONFIG_DISABLE); > + if (ret) > + dev_err(dev, "failed to write system register\n"); Unrelated to your patch, but I wonder if there is appetite for regmap_err(data->regmap, "failed to write system register\n"); A lot of drivers carry a local dev pointer because the regmap_get_device() stuff is a bit clunky. They only use it in many paths for prints like this. > } > @@ -204,7 +210,9 @@ static int al3010_suspend(struct device *dev) > > static int al3010_resume(struct device *dev) > { > - return al3010_set_pwr_on(to_i2c_client(dev)); > + struct al3010_data *data = iio_priv(dev_get_drvdata(dev)); Why this change? > + > + return al3010_set_pwr_on(data); > } > > static DEFINE_SIMPLE_DEV_PM_OPS(al3010_pm_ops, al3010_suspend, al3010_resume); >