Re: [PATCH 1/2] dt-bindings: iio: imu: icm42600: add interrupt naming support

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1866 bytes --]

On Fri, Apr 04, 2025 at 05:52:02PM +0200, Jean-Baptiste Maneyrol via B4 Relay wrote:
> From: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
> 
> Add interrupt-names field for specifying interrupt used.
> Only INT1 is supported by the driver currently.
> ---
>  .../devicetree/bindings/iio/imu/invensense,icm42600.yaml          | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml b/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml
> index 7e4492bbd0278a336587dc5ac04da7153453da29..f19cdfd7450e04e7c984dc987f3c23f5ad89a248 100644
> --- a/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml
> +++ b/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml
> @@ -41,6 +41,12 @@ properties:
>    interrupts:
>      maxItems: 1
>  
> +  interrupt-names:
> +    enum:
> +      - INT1

An enum with one entry is just a const.

> +    description: |
> +      set to "INT1" the only supported interrupts pin

The commit message suggests there are others, you should list them all
here (if there are) even if the driver doesn't use them.

> +
>    drive-open-drain:
>      type: boolean
>  
> @@ -76,6 +82,7 @@ examples:
>              reg = <0x68>;
>              interrupt-parent = <&gpio2>;
>              interrupts = <7 IRQ_TYPE_EDGE_FALLING>;
> +            interrupt-names = "INT1";
>              vdd-supply = <&vdd>;
>              vddio-supply = <&vddio>;
>          };
> @@ -95,6 +102,7 @@ examples:
>              spi-cpol;
>              interrupt-parent = <&gpio1>;
>              interrupts = <2 IRQ_TYPE_EDGE_FALLING>;
> +            interrupt-names = "INT1";
>              vdd-supply = <&vdd>;
>              vddio-supply = <&vddio>;
>          };
> 
> -- 
> 2.49.0
> 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]