Re: [PATCH v2 0/3] iio: adc: ad7124: Fix 3dB filter frequency reading

[Jonathan Cameron <jic23@kernel.org>]

On Mon, 31 Mar 2025 11:02:14 +0100
Jonathan Cameron <jic23@kernel.org> wrote:

> On Mon, 24 Mar 2025 10:44:52 +0100
> Uwe Kleine-König <u.kleine-koenig@baylibre.com> wrote:
> 
> > Hello Jonathan,
> > 
> > On Mon, Mar 17, 2025 at 07:00:31PM +0000, Jonathan Cameron wrote:  
> > > On Mon, 17 Mar 2025 12:52:46 +0100
> > > Uwe Kleine-König <u.kleine-koenig@baylibre.com> wrote:
> > >     
> > > > Hello,
> > > > 
> > > > (implicit) v1 of this patch set is available at
> > > > https://lore.kernel.org/linux-iio/cover.1741801853.git.u.kleine-koenig@baylibre.com
> > > > .
> > > > 
> > > > Changes since then:
> > > > 
> > > >  - Reorder patches to have the cleanup ("Make register naming
> > > >    consistent") last
> > > >  - Drop write support for the filter_low_pass_3db_frequency property
> > > >    which is completely broken.
> > > >  - trivially rebase to todays iio/togreg
> > > > 
> > > > I wonder if there is a way to remove the writable permission of the
> > > > filter_low_pass_3db_frequency sysfs file instead of erroring out when a
> > > > value is written. Hints welcome.    
> > > 
> > > Unfortunately not. With a lot of hindsight that is a flaw in the way
> > > we generate sysfs attributes. IIRC when hwmon added similar they
> > > avoided that trap.  To retrofit it onto IIO now we'd have to have
> > > some form of complex permissions query or duplicate all the masks
> > > to allow r and w separately.    
> > 
> > OK, fine for me, so I didn't miss anything :-)
> > 
> > I have another patch in my queue for ad7124. For that it would be great
> > to know if you intend to apply this patch set. If yes, I continue to
> > build on top of this stack.  
> 
> Sorry for slow reply.  Bunch of travel (and being a tourist on either end
> of the work bit ;)
> 
> Subject to the question on patch 1 from Marcelo I'm fine with this.
> 
> I'll probably take all 3 for next merge window though as patch 1 is
> a minor fix I think in something that people probably haven't really 
> been using and splitting it makes for a messy cycle.
> 
Not sure how I managed it, but I had patch 2 already on my tree. Anyhow
backed that out and applied the whole series to the testing branch of iio.git.

Thanks,

Jonathan

> Jonathan
> 
> 
> 
> > 
> > Best regards
> > Uwe  
> 
>