Re: [PATCH 06/16] iio: accel: Use iio_push_to_buffers_with_ts() to provide length for runtime checks.

[Jonathan Cameron <jic23@kernel.org>]

On Mon, 10 Mar 2025 17:20:33 -0500
David Lechner <dlechner@baylibre.com> wrote:

> On 3/9/25 1:20 PM, Jonathan Cameron wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > 
> > This new function allows us to perform debug checks in the helper to ensure
> > that the overrun does not occur.  Use it in all the simple cases where
> > either a static buffer or a structure is used in the drivers.
> > 
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > ---
> >  drivers/iio/accel/adxl355_core.c    | 4 ++--
> >  drivers/iio/accel/bma180.c          | 3 ++-
> >  drivers/iio/accel/bma220_spi.c      | 4 ++--
> >  drivers/iio/accel/bma400_core.c     | 5 +++--
> >  drivers/iio/accel/fxls8962af-core.c | 4 ++--
> >  drivers/iio/accel/kxcjk-1013.c      | 4 ++--
> >  drivers/iio/accel/kxsd9.c           | 5 ++---
> >  drivers/iio/accel/mma7455_core.c    | 5 +++--
> >  drivers/iio/accel/mma8452.c         | 5 +++--
> >  drivers/iio/accel/msa311.c          | 4 ++--
> >  drivers/iio/accel/mxc4005.c         | 4 ++--
> >  drivers/iio/accel/sca3300.c         | 5 +++--
> >  drivers/iio/accel/stk8312.c         | 2 +-
> >  drivers/iio/accel/stk8ba50.c        | 4 ++--
> >  14 files changed, 31 insertions(+), 27 deletions(-)
> > 
> > diff --git a/drivers/iio/accel/adxl355_core.c b/drivers/iio/accel/adxl355_core.c
> > index e8cd21fa77a6..ae949ada6db5 100644
> > --- a/drivers/iio/accel/adxl355_core.c
> > +++ b/drivers/iio/accel/adxl355_core.c
> > @@ -666,8 +666,8 @@ static irqreturn_t adxl355_trigger_handler(int irq, void *p)
> >  	if (ret)
> >  		goto out_unlock_notify;
> >  
> > -	iio_push_to_buffers_with_timestamp(indio_dev, &data->buffer,
> > -					   pf->timestamp);
> > +	iio_push_to_buffers_with_ts(indio_dev, &data->buffer,  
> 
> Could also use aligned_s64 in the declaration of buffer.ts.
I think that's a bug given it might be 32 bit aligned (we love x86_32)
and the structure come up short.  

> 
> > +				    sizeof(data->buffer), pf->timestamp);
> >  
> >  out_unlock_notify:
> >  	mutex_unlock(&data->lock);  
> 
> The rest check out.
> 
> Reviewed-by: David Lechner <dlechner@baylibre.com>
> 
>