Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Jorge Marques <gastmaier@gmail.com>
Cc: David Lechner <dlechner@baylibre.com>,
	Jorge Marques <jorge.marques@analog.com>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Michael.Hennerich@analog.com, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Documentation: ABI: add oversampling frequency in sysfs-bus-iio
Date: Mon, 7 Apr 2025 19:40:35 +0100	[thread overview]
Message-ID: <20250407194035.6c7802a1@jic23-huawei> (raw)
In-Reply-To: <c53je4hfe76lergtxq2fhoouuer5upla34jd2sq5sdg3kw3rsk@6pjgmuevotnc>


> 
> All things considered, I believe the appropriate ABI documentation is the following
> 
> 
>   What:                /sys/bus/iio/devices/iio:deviceX/oversampling_frequency
>   KernelVersion:       6.15
>   Contact:     linux-iio@vger.kernel.org
>   Description:
>            Some devices have internal clocks for oversampling.
>            Sets the resulting frequency to trigger a conversion used by the
>            oversampling filter.
>            If the device has a fixed internal clock or is computed based on
>            the sampling frequency parameter, the parameter is read only.
> 
> If that's ok I'll resubmit the patch including only this commit,
> and then focus on submitting AD4052 driver V2 series.

Looks good to me with one addition.  Mention the units (Hz)

Jonathan

> 
> Jorge


      reply	other threads:[~2025-04-07 18:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-21 14:50 [PATCH 0/2] Add sys-bus-iio ABI frequency options to events and oversampling Jorge Marques
2025-03-21 14:50 ` [PATCH 1/2] Documentation: ABI: add events sampling frequency in sysfs-bus-iio Jorge Marques
2025-03-30 17:08   ` Jonathan Cameron
2025-03-21 14:50 ` [PATCH 2/2] Documentation: ABI: add oversampling " Jorge Marques
2025-03-30 17:13   ` Jonathan Cameron
2025-03-30 17:34     ` David Lechner
2025-03-30 17:53       ` Jonathan Cameron
2025-04-02 13:47         ` Jorge Marques
2025-04-02 20:27           ` David Lechner
2025-04-03  8:35             ` Jorge Marques
2025-04-06 10:25               ` Jonathan Cameron
2025-04-07 16:28                 ` Jorge Marques
2025-04-07 18:40                   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250407194035.6c7802a1@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=dlechner@baylibre.com \
    --cc=gastmaier@gmail.com \
    --cc=jorge.marques@analog.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox