Re: [PATCH v2 09/20] iio: adc: Use iio_push_to_buffers_with_ts() to provide length for runtime checks.

[Jonathan Cameron <jic23@kernel.org>]

On Mon, 7 Apr 2025 12:30:44 +0300
Andy Shevchenko <andy@kernel.org> wrote:

> On Sun, Apr 06, 2025 at 06:19:50PM +0100, Jonathan Cameron wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > 
> > This new function allows us to perform debug checks in the helper to ensure
> > that the overrun does not occur.  Use it in all the simple cases where
> > either a static buffer or a structure is used in the drivers.  
> 
> ...
> 
> > -	iio_push_to_buffers_with_timestamp(indio_dev, &chip->scan, time);
> > +	iio_push_to_buffers_with_ts(indio_dev, &chip->scan, sizeof(chip->scan),
> > +				    time);  
> 
> I think readability is better when this occupies a single line.

Rare case where I think you cut too much.  Not obvious from that snippet
which driver it is in!

I tweaked a bunch of them to allow just over 80 chars 


> 
> ...
> 
> > +	iio_push_to_buffers_with_ts(indio_dev, priv->buffer,
> > +				    sizeof(priv->buffer), pf->timestamp);  
> 
> Isn't it enough room for one parameter on the previous line?
Strictly speaking nope. 82 chars, but meh I'm slowly being more flexible on this

> 
> ...
> 
> > +			iio_push_to_buffers_with_ts(indio_dev,
> > +						    &info->scan,  
> 
> In all other places you put these two on one line.
True enough. That one was accidental.

Jonathan

> 
> > +						    sizeof(info->scan),
> > +						    iio_get_time_ns(indio_dev));  
>