Re: [PATCH 1/2] iio: adc: ad7476: modernize single regulator call

[Jonathan Cameron <jic23@kernel.org>]

On Tue, 29 Apr 2025 13:05:18 -0300
Cesar Bispo <dm.cesaraugusto@gmail.com> wrote:

> Replace a single instance of legacy regulator handling in each driver
> with devm_regulator_get_enable() and devm_regulator_get_enable_optional().
> This change improves code clarity and aligns with modern kernel APIs.
> 
> Signed-off-by: Cesar Bispo <cesar.bispo@ime.usp.br>
> Co-developed-by: GabrIel Ferreira <gabrielfsouza.araujo@usp.br>
> Signed-off-by: GabrIel Ferreira <gabrielfsouza.araujo@usp.br>
Take a closer look at the signatures of these functions.

I'm a bit surprised if this builds.
> ---
>  drivers/iio/adc/ad7476.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/adc/ad7476.c b/drivers/iio/adc/ad7476.c
> index 37b0515cf4fc..33155f76230e 100644
> --- a/drivers/iio/adc/ad7476.c
> +++ b/drivers/iio/adc/ad7476.c
> @@ -314,7 +314,7 @@ static int ad7476_probe(struct spi_device *spi)
>  	st->chip_info =
>  		&ad7476_chip_info_tbl[spi_get_device_id(spi)->driver_data];
>  
> -	reg = devm_regulator_get(&spi->dev, "vcc");
> +	reg = devm_regulator_get_enable(&spi->dev, "vcc");
>  	if (IS_ERR(reg))
>  		return PTR_ERR(reg);
>  
> @@ -334,11 +334,11 @@ static int ad7476_probe(struct spi_device *spi)
>  
>  		/* If a device has an internal reference vref is optional */
>  		if (st->chip_info->int_vref_uv) {
> -			reg = devm_regulator_get_optional(&spi->dev, "vref");
> +			reg = devm_regulator_get_enable_optional(&spi->dev, "vref");
>  			if (IS_ERR(reg) && (PTR_ERR(reg) != -ENODEV))
>  				return PTR_ERR(reg);
>  		} else {
> -			reg = devm_regulator_get(&spi->dev, "vref");
> +			reg = devm_regulator_get_enable(&spi->dev, "vref");
>  			if (IS_ERR(reg))
>  				return PTR_ERR(reg);
>  		}