Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: r2.arthur.prince@gmail.com
Cc: linux-iio@vger.kernel.org, arthur.prince@ime.usp.br,
	"Mariana Valério" <mariana.valerio2@hotmail.com>
Subject: Re: [PATCH] iio: adc: Kconfig: add kfifo dependency to fix module build
Date: Wed, 7 May 2025 19:49:44 +0100	[thread overview]
Message-ID: <20250507194944.438bf897@jic23-huawei> (raw)
In-Reply-To: <20250504174643.40feaa67@jic23-huawei>

On Sun, 4 May 2025 17:46:43 +0100
Jonathan Cameron <jic23@kernel.org> wrote:

> On Wed, 30 Apr 2025 16:07:37 -0300
> r2.arthur.prince@gmail.com wrote:
> 
> > From: Arthur-Prince <r2.arthur.prince@gmail.com>
> > 
> > Add dependency to Kconfig’s ti-ads1298 because compiling it as a module
> > failed with an undefined kfifo symbol.
> > 
> > Fixes: 00ef7708fa6 ("iio: adc: ti-ads1298: Add driver")
> > Signed-off-by: Arthur-Prince <r2.arthur.prince@gmail.com>
> > Co-developed-by: Mariana Valério <mariana.valerio2@hotmail.com>
> > Signed-off-by: Mariana Valério <mariana.valerio2@hotmail.com>  
> Applied and marked for stable

So we had a clash between this which was in the fixes-togreg branch
with a tidy up of ordering that was in the togreg branch.

Given this wasn't a new bug, I've shifted this to the togreg branch so
I could resolve this without much mess (the ordering patch was way down
my togreg branch whereas this was near the top of the fixes one)

Slight delay in this fix getting upstream as a result.

Jonathan

> 
> > ---
> >  drivers/iio/adc/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> > index 849c90203071..513f2238fdee 100644
> > --- a/drivers/iio/adc/Kconfig
> > +++ b/drivers/iio/adc/Kconfig
> > @@ -1492,6 +1492,7 @@ config TI_ADS1298
> >  	tristate "Texas Instruments ADS1298"
> >  	depends on SPI
> >  	select IIO_BUFFER
> > +	select IIO_KFIFO_BUF
> >  	help
> >  	  If you say yes here you get support for Texas Instruments ADS1298
> >  	  medical ADC chips  
> 
> 


      reply	other threads:[~2025-05-07 18:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-30 19:07 [PATCH] iio: adc: Kconfig: add kfifo dependency to fix module build r2.arthur.prince
2025-05-04 16:46 ` Jonathan Cameron
2025-05-07 18:49   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250507194944.438bf897@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=arthur.prince@ime.usp.br \
    --cc=linux-iio@vger.kernel.org \
    --cc=mariana.valerio2@hotmail.com \
    --cc=r2.arthur.prince@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox