From: Jonathan Cameron <jic23@kernel.org>
To: David Lechner <dlechner@baylibre.com>
Cc: "Colin Ian King" <colin.i.king@gmail.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Antoniu Miclaus" <antoniu.miclaus@analog.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] iio: admv1013: replace redundant ternary operator with just len
Date: Thu, 8 May 2025 20:13:48 +0100 [thread overview]
Message-ID: <20250508201348.61494209@jic23-huawei> (raw)
In-Reply-To: <fbf6c7ef-3680-40ec-8c90-121e6a635b8d@baylibre.com>
On Wed, 7 May 2025 08:49:46 -0500
David Lechner <dlechner@baylibre.com> wrote:
> On 5/7/25 8:45 AM, Colin Ian King wrote:
> > The variable ret is being assigned a return value and non-zero error
> > return paths are taken at all stages. At the end of the function ret
> > is always zero, so the ternary operator checking for zero ret is
> > redundant and can be replaced with just len instead.
> >
> > Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> > ---
>
> Reviewed-by: David Lechner <dlechner@baylibre.com>
>
Applied.
prev parent reply other threads:[~2025-05-08 19:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-07 13:45 [PATCH][next] iio: admv1013: replace redundant ternary operator with just len Colin Ian King
2025-05-07 13:49 ` David Lechner
2025-05-08 19:13 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250508201348.61494209@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=colin.i.king@gmail.com \
--cc=dlechner@baylibre.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox