From: Jonathan Cameron <jic23@kernel.org>
To: Andrew Ijano <andrew.ijano@gmail.com>
Cc: andrew.lopes@alumni.usp.br, gustavobastos@usp.br,
David Lechner <dlechner@baylibre.com>,
nuno.sa@analog.com, andy@kernel.org, jstephan@baylibre.com,
linux-iio <linux-iio@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] iio: accel: sca3000: replace usages of internal read data helpers by spi helpers
Date: Thu, 15 May 2025 17:53:26 +0100 [thread overview]
Message-ID: <20250515175326.67615d3b@jic23-huawei> (raw)
In-Reply-To: <CANZih_SmneYr+jK9Apuif66vfCcpni7K+CzMk32-hZt-LRrZWw@mail.gmail.com>
> > > }
> > > @@ -432,13 +434,13 @@ static int sca3000_print_rev(struct iio_dev *indio_dev)
> > > struct sca3000_state *st = iio_priv(indio_dev);
> > >
> > > mutex_lock(&st->lock);
> >
> > Another patch to use guard(mutex)(&st->lock); etc would be help clean this
> > up by allowing direct return in the error path.
>
> Great! In this case, would you suggest the following order?
> 1. One patch for general style changes, like the removal of error_ret labels;
> 2. Another patch for spi changes;
> 3. And another one for using guard(mutex)(&st->lock).
That order is fine.
J
prev parent reply other threads:[~2025-05-15 16:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-10 19:07 [PATCH v4] iio: accel: sca3000: replace usages of internal read data helpers by spi helpers Andrew Ijano
2025-05-10 21:39 ` Andy Shevchenko
2025-05-11 17:35 ` Andrew Ijano
2025-05-11 11:34 ` Jonathan Cameron
[not found] ` <CANZih_QHNEuFTQ2NysUVOJ-PmrL-ASFeG5b8xBTbRSG=3ho-vw@mail.gmail.com>
2025-05-11 18:36 ` Fwd: " Andrew Ijano
2025-05-15 16:53 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250515175326.67615d3b@jic23-huawei \
--to=jic23@kernel.org \
--cc=andrew.ijano@gmail.com \
--cc=andrew.lopes@alumni.usp.br \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gustavobastos@usp.br \
--cc=jstephan@baylibre.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox