From: Jonathan Cameron <jic23@kernel.org>
To: "Nuno Sá" <noname.nuno@gmail.com>
Cc: Antoniu Miclaus <antoniu.miclaus@analog.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] iio: adc: ad4080: use lowercase device name
Date: Sun, 25 May 2025 15:11:18 +0100 [thread overview]
Message-ID: <20250525151118.1384a139@jic23-huawei> (raw)
In-Reply-To: <5e0eb8b91062a5622b09c5e32f9e662a224d8d80.camel@gmail.com>
On Tue, 20 May 2025 15:08:52 +0100
Nuno Sá <noname.nuno@gmail.com> wrote:
> On Tue, 2025-05-20 at 14:01 +0300, Antoniu Miclaus wrote:
> > Update the .name field in the ad4080_chip_info struct
> > from "AD4080" to "ad4080" to follow the common convention
> > in IIO drivers of using lowercase names for device identifiers.
> >
> > No functional changes are introduced.
Isn't this what is read back from /sys/bus/iio/devices/iio\:device0/name?
changing it is a functional change. I'd argue it's a fix and deserved
a fixed tag.
> >
> > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> > ---
>
> Reviewed-by: Nuno Sá <nuno.sa@analog.com>
>
> > drivers/iio/adc/ad4080.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/adc/ad4080.c b/drivers/iio/adc/ad4080.c
> > index e8b2e5e7a68a..c36eb41d738a 100644
> > --- a/drivers/iio/adc/ad4080.c
> > +++ b/drivers/iio/adc/ad4080.c
> > @@ -433,7 +433,7 @@ static const struct iio_chan_spec ad4080_channel = {
> > };
> >
> > static const struct ad4080_chip_info ad4080_chip_info = {
> > - .name = "AD4080",
> > + .name = "ad4080",
> > .product_id = AD4080_CHIP_ID,
> > .scale_table = ad4080_scale_table,
> > .num_scales = ARRAY_SIZE(ad4080_scale_table),
>
prev parent reply other threads:[~2025-05-25 14:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-20 11:01 [PATCH 1/2] iio: adc: ad4080: use lowercase device name Antoniu Miclaus
2025-05-20 11:01 ` [PATCH 2/2] iio: adc: ad4080: extend check for data lanes num Antoniu Miclaus
2025-05-20 14:09 ` Nuno Sá
2025-05-25 14:12 ` Jonathan Cameron
2025-05-20 14:08 ` [PATCH 1/2] iio: adc: ad4080: use lowercase device name Nuno Sá
2025-05-25 14:11 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250525151118.1384a139@jic23-huawei \
--to=jic23@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noname.nuno@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox