[PATCH v2] dt-bindings: iio: gyroscope: invensense,itg3200: add binding

[PATCH v2] dt-bindings: iio: gyroscope: invensense,itg3200: add binding

[Rodrigo Gobbi]

There is no txt file for it, add yaml for invensense,itg3200 gyroscope.

Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>
---
Originally I`ve added @Jonathan as the binding maintainer due another thread
but @Krzysztof mentioned at v1: "...this should be someone interested in the hardware".
I`m not sure who might be this person in this case, a reasonable choice would be
the original author of the driver, but looks like his last patch is from a
long time ago [2] but I`ll ping here.

Dear @Manuel Stahl, I`ve noticed that since the driver was added,
there was no binding doc for it and this is what this patch is addressing.
In this case, a maintainer ref is required inside the .yaml file and I would
like to ask if I can add you in this case. 
I would appreciate your comment or suggestion over this topic.

Tks all and regards.

Changelog:
v2: 
    - removed the register map link; there is no datasheet available at public ref. At [1],
    it is just a product overview, so we can`t use it;
    - add supplies and external clocks (I`ve used as ref iio/gyroscope/invensense,mpu3050.yaml);
    - add the author of the driver as the maintainer of this file but I`m CC him in
    order to get his opinion about it;
    - adding some CC missing at v1;

v1: https://lore.kernel.org/linux-devicetree/20250515002817.81863-1-rodrigo.gobbi.7@gmail.com/

[1] https://invensense.tdk.com/products/motion-tracking/3-axis/itg-3200/
[2] https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/?qt=author&q=Manuel+Stahl
---
 .../iio/gyroscope/invensense,itg3200.yaml     | 59 +++++++++++++++++++
 1 file changed, 59 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/gyroscope/invensense,itg3200.yaml

diff --git a/Documentation/devicetree/bindings/iio/gyroscope/invensense,itg3200.yaml b/Documentation/devicetree/bindings/iio/gyroscope/invensense,itg3200.yaml
new file mode 100644
index 000000000000..4b2f9a57c6ea
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/gyroscope/invensense,itg3200.yaml
@@ -0,0 +1,59 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/gyroscope/invensense,itg3200.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Invensense ITG-3200 Gyroscope
+
+maintainers:
+  - Manuel Stahl <manuel.stahl@iis.fraunhofer.de>
+
+description: |
+  Triple-axis, digital output gyroscope with a three 16-bit analog-to-digital
+  converters (ADCs) for digitizing the gyro outputs, a user-selectable internal
+  low-pass filter bandwidth, and a Fast-Mode I2C.
+
+properties:
+  compatible:
+    const: invensense,itg3200
+
+  reg:
+    maxItems: 1
+
+  vdd-supply: true
+
+  vlogic-supply: true
+
+  interrupts:
+    maxItems: 1
+
+  mount-matrix:
+    description: an optional 3x3 mounting rotation matrix.
+
+  clocks:
+    maxItems: 1
+
+  clock-names:
+    items:
+      - const: ext_clock
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+        gyroscope@68 {
+            compatible = "invensense,itg3200";
+            reg = <0x68>;
+            interrupt-parent = <&gpio2>;
+            interrupts = <24 IRQ_TYPE_EDGE_FALLING>;
+        };
+    };
-- 
2.49.0

Re: [PATCH v2] dt-bindings: iio: gyroscope: invensense,itg3200: add binding

[Krzysztof Kozlowski]

On 27/05/2025 22:55, Rodrigo Gobbi wrote:
> There is no txt file for it, add yaml for invensense,itg3200 gyroscope.

... which is already used in DTS and driver.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH v2] dt-bindings: iio: gyroscope: invensense,itg3200: add binding

[Jonathan Cameron]

On Tue, 27 May 2025 17:55:28 -0300
Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com> wrote:

> There is no txt file for it, add yaml for invensense,itg3200 gyroscope.
> 
> Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>
> ---
> Originally I`ve added @Jonathan as the binding maintainer due another thread
> but @Krzysztof mentioned at v1: "...this should be someone interested in the hardware".
> I`m not sure who might be this person in this case, a reasonable choice would be
> the original author of the driver, but looks like his last patch is from a
> long time ago [2] but I`ll ping here.
> 
> Dear @Manuel Stahl, I`ve noticed that since the driver was added,
> there was no binding doc for it and this is what this patch is addressing.
> In this case, a maintainer ref is required inside the .yaml file and I would
> like to ask if I can add you in this case. 
> I would appreciate your comment or suggestion over this topic.

Manuel has not been active for quite a while. You never know though!

Fall back to me if needed given I end up seeing all these changes anyway.

I can make that change whilst applying.

Jonathan

> 
> Tks all and regards.
> 
> Changelog:
> v2: 
>     - removed the register map link; there is no datasheet available at public ref. At [1],
>     it is just a product overview, so we can`t use it;
>     - add supplies and external clocks (I`ve used as ref iio/gyroscope/invensense,mpu3050.yaml);
>     - add the author of the driver as the maintainer of this file but I`m CC him in
>     order to get his opinion about it;
>     - adding some CC missing at v1;
> 
> v1: https://lore.kernel.org/linux-devicetree/20250515002817.81863-1-rodrigo.gobbi.7@gmail.com/
> 
> [1] https://invensense.tdk.com/products/motion-tracking/3-axis/itg-3200/
> [2] https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/?qt=author&q=Manuel+Stahl
> ---
>  .../iio/gyroscope/invensense,itg3200.yaml     | 59 +++++++++++++++++++
>  1 file changed, 59 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/gyroscope/invensense,itg3200.yaml
> 
> diff --git a/Documentation/devicetree/bindings/iio/gyroscope/invensense,itg3200.yaml b/Documentation/devicetree/bindings/iio/gyroscope/invensense,itg3200.yaml
> new file mode 100644
> index 000000000000..4b2f9a57c6ea
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/gyroscope/invensense,itg3200.yaml
> @@ -0,0 +1,59 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/gyroscope/invensense,itg3200.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Invensense ITG-3200 Gyroscope
> +
> +maintainers:
> +  - Manuel Stahl <manuel.stahl@iis.fraunhofer.de>
> +
> +description: |
> +  Triple-axis, digital output gyroscope with a three 16-bit analog-to-digital
> +  converters (ADCs) for digitizing the gyro outputs, a user-selectable internal
> +  low-pass filter bandwidth, and a Fast-Mode I2C.
> +
> +properties:
> +  compatible:
> +    const: invensense,itg3200
> +
> +  reg:
> +    maxItems: 1
> +
> +  vdd-supply: true
> +
> +  vlogic-supply: true
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  mount-matrix:
> +    description: an optional 3x3 mounting rotation matrix.
> +
> +  clocks:
> +    maxItems: 1
> +
> +  clock-names:
> +    items:
> +      - const: ext_clock
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +        gyroscope@68 {
> +            compatible = "invensense,itg3200";
> +            reg = <0x68>;
> +            interrupt-parent = <&gpio2>;
> +            interrupts = <24 IRQ_TYPE_EDGE_FALLING>;
> +        };
> +    };

Re: [PATCH v2] dt-bindings: iio: gyroscope: invensense,itg3200: add binding

[Jonathan Cameron]

On Fri, 30 May 2025 17:56:49 +0100
Jonathan Cameron <Jonathan.Cameron@huawei.com> wrote:

> On Tue, 27 May 2025 17:55:28 -0300
> Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com> wrote:
> 
> > There is no txt file for it, add yaml for invensense,itg3200 gyroscope.
> > 
> > Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>
> > ---
> > Originally I`ve added @Jonathan as the binding maintainer due another thread
> > but @Krzysztof mentioned at v1: "...this should be someone interested in the hardware".
> > I`m not sure who might be this person in this case, a reasonable choice would be
> > the original author of the driver, but looks like his last patch is from a
> > long time ago [2] but I`ll ping here.
> > 
> > Dear @Manuel Stahl, I`ve noticed that since the driver was added,
> > there was no binding doc for it and this is what this patch is addressing.
> > In this case, a maintainer ref is required inside the .yaml file and I would
> > like to ask if I can add you in this case. 
> > I would appreciate your comment or suggestion over this topic.  
> 
> Manuel has not been active for quite a while. You never know though!
> 
> Fall back to me if needed given I end up seeing all these changes anyway.
> 
> I can make that change whilst applying.
> 
Tweaked to change this and add the note from Krzysztof to the commit
message. Applied

Thanks,

Jonathan

> Jonathan
> 
> > 
> > Tks all and regards.
> > 
> > Changelog:
> > v2: 
> >     - removed the register map link; there is no datasheet available at public ref. At [1],
> >     it is just a product overview, so we can`t use it;
> >     - add supplies and external clocks (I`ve used as ref iio/gyroscope/invensense,mpu3050.yaml);
> >     - add the author of the driver as the maintainer of this file but I`m CC him in
> >     order to get his opinion about it;
> >     - adding some CC missing at v1;
> > 
> > v1: https://lore.kernel.org/linux-devicetree/20250515002817.81863-1-rodrigo.gobbi.7@gmail.com/
> > 
> > [1] https://invensense.tdk.com/products/motion-tracking/3-axis/itg-3200/
> > [2] https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/?qt=author&q=Manuel+Stahl
> > ---
> >  .../iio/gyroscope/invensense,itg3200.yaml     | 59 +++++++++++++++++++
> >  1 file changed, 59 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/iio/gyroscope/invensense,itg3200.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/gyroscope/invensense,itg3200.yaml b/Documentation/devicetree/bindings/iio/gyroscope/invensense,itg3200.yaml
> > new file mode 100644
> > index 000000000000..4b2f9a57c6ea
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/gyroscope/invensense,itg3200.yaml
> > @@ -0,0 +1,59 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/iio/gyroscope/invensense,itg3200.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Invensense ITG-3200 Gyroscope
> > +
> > +maintainers:
> > +  - Manuel Stahl <manuel.stahl@iis.fraunhofer.de>
> > +
> > +description: |
> > +  Triple-axis, digital output gyroscope with a three 16-bit analog-to-digital
> > +  converters (ADCs) for digitizing the gyro outputs, a user-selectable internal
> > +  low-pass filter bandwidth, and a Fast-Mode I2C.
> > +
> > +properties:
> > +  compatible:
> > +    const: invensense,itg3200
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  vdd-supply: true
> > +
> > +  vlogic-supply: true
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  mount-matrix:
> > +    description: an optional 3x3 mounting rotation matrix.
> > +
> > +  clocks:
> > +    maxItems: 1
> > +
> > +  clock-names:
> > +    items:
> > +      - const: ext_clock
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/irq.h>
> > +    i2c {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +        gyroscope@68 {
> > +            compatible = "invensense,itg3200";
> > +            reg = <0x68>;
> > +            interrupt-parent = <&gpio2>;
> > +            interrupts = <24 IRQ_TYPE_EDGE_FALLING>;
> > +        };
> > +    };  
>